[Amdatu-commits] SVN r2511 - branches/amdatu-opensocial-0.2.2/opensocial-shindig/src/main/java/org/amdatu/opensocial/shindig/config

[subversion]

Author: ivo...@gmail.com
Date: Fri Jun 22 14:33:54 2012
New Revision: 2511

Log:
[AMDATUOPENSOCIAL-227] Fixed possible concurrency issue

Modified:
   
branches/amdatu-opensocial-0.2.2/opensocial-shindig/src/main/java/org/amdatu/opensocial/shindig/config/ShindigConfigurationServiceImpl.java

Modified: 
branches/amdatu-opensocial-0.2.2/opensocial-shindig/src/main/java/org/amdatu/opensocial/shindig/config/ShindigConfigurationServiceImpl.java
==============================================================================
--- 
branches/amdatu-opensocial-0.2.2/opensocial-shindig/src/main/java/org/amdatu/opensocial/shindig/config/ShindigConfigurationServiceImpl.java
 (original)
+++ 
branches/amdatu-opensocial-0.2.2/opensocial-shindig/src/main/java/org/amdatu/opensocial/shindig/config/ShindigConfigurationServiceImpl.java
 Fri Jun 22 14:33:54 2012
@@ -61,15 +61,17 @@
         m_listeners.remove(listener);
     }
 
-    public void start() {
+    public synchronized void start() {
         initConfigTools();
     }
 
-    public void updated(final Dictionary properties) throws 
ConfigurationException {
-        m_dictionary = properties;
-        initConfigTools();
-        for (Listener listener : m_listeners) {
-            listener.onConfigUpdate(properties);
+    public synchronized void updated(final Dictionary properties) throws 
ConfigurationException {
+        if (properties != null) {
+            m_dictionary = properties;
+            initConfigTools();
+            for (Listener listener : m_listeners) {
+                listener.onConfigUpdate(properties);
+            }
         }
     }
 
@@ -82,15 +84,15 @@
         }
     }
 
-    public <T> T get(final String key, final Class<T> clazz) {
+    public synchronized <T> T get(final String key, final Class<T> clazz) {
         return m_configTools.get(key, clazz);
     }
 
-    public Dictionary getDictionary() {
+    public synchronized Dictionary getDictionary() {
         return m_dictionary;
     }
 
-    public Properties getProperties() {
+    public synchronized Properties getProperties() {
         Properties properties = new Properties();
         Enumeration keys = m_dictionary.keys();
         while (keys.hasMoreElements()) {
_______________________________________________
Amdatu-commits mailing list
Amdatu-commits@amdatu.org
http://lists.amdatu.org/mailman/listinfo/amdatu-commits