[
http://jira.amdatu.org/jira/browse/AMDATU-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11094#comment-11094
]
Ivo Ladage - van Doorn commented on AMDATU-283:
-----------------------------------------------
My comments:
- In this refactoring mimetype resolving is handled by Felix instead of Sling.
I doubt if this is the right choice; Felix hardcoded list of mimetypes is quite
limited w.r.t. the Sling list (Default Sling list contains 10 times more
mimetypes) and is not extensible and editable like the Sling version is (Web UI
integrated as plugin in Felix web console). But when we choose to use Felix
instead, the Sling bundles are redundant and should thus be removed (they are
still there)
- WAR deployment seems to be broken for context paths other then ''. For
example with context path /amdatu, /amdatu/system/console/bundles works, but
/amdatu/dashboard/jsp/dashboard.jsp returns a 404.
- There seems to be no unit test nor integration test that actually uses
MimeTypeResolver or SecurityHandler, so this is untested.
- init/destroy in AbstractHandler is not implemented properly w.r.t.
concurrency; init and destroy may be invoked simultaneously.
- more concurrency issues in ResourceProviderListener; reentrant read/write
locks have been added in the past to resolve concurrency issues with
simultaneous invocations of destroy, onAdded and onRemoved. With this
refactoring these locks have been removed and so the issue is reintroduced.
- fix the FIXME's
- Fix use of e.printStackTrace();
- if you stop the http context bundle, Amdatu halts/stops completely
- stop/start the dispatcher bundle causes many errors and stacktraces
Documentation related:
- Add javadoc to public interfaces (i.e. to ResourceProvider, MimeTypeResolver,
SecurityHandler)
- Copyright statement is missing on some files (i.e. HttpContextManagerService,
MimeTypeResolver, SecurityHandler, JspSupport)
- Add a WIKI page for 0.2.0 to
http://www.amdatu.org/confluence/display/Amdatu/News and describe in detail the
steps involved how to migrate existing code from 0.1.1 to 0.2.0
- Update the WIKI
(http://www.amdatu.org/confluence/display/Amdatu/Add+a+resource+to+a+bundle,
http://www.amdatu.org/confluence/display/Amdatu/Add+a+resource+to+a+bundle and
http://www.amdatu.org/confluence/display/Amdatu/Use+JSPs)
Furthermore I performed a performance test (Amdatu dashboard.jmx) between 0.2.0
before vs after refactoring. The results show no significant changes in
performance.
> Refactor web httpcontext mechanism
> ----------------------------------
>
> Key: AMDATU-283
> URL: http://jira.amdatu.org/jira/browse/AMDATU-283
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Web
> Affects Versions: 0.1.0
> Reporter: Bram de Kruijff
> Assignee: Ivo Ladage - van Doorn
> Fix For: 0.2.0
>
> Attachments: AMDATU-283-v1.patch
>
>
> As discussed and documented at
> http://lists.amdatu.org/pipermail/amdatu-developers/2011-January/002474.html
> the current HttpContext requires some refactoring to be really usefull and
> support advanced use cases (including security).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
