Hello Ivo, Let me get back to you about this in more detail on Monday afternoon. In sort, the code is used in a project that builds on top of Amdatu so you're right that there is no example. Also, the code builds on (now obsolete) amdatu-web code (that has since been rewritten in amdatu.org). The sandbox was more or less put there "as is" and I think it makes sense to work together to get this stuff backported and changed.
Greetings, Marcel On Sep 30, 2011, at 3:15 PM, Ivo Ladage-van Doorn wrote: > Hi All, > > Soon we would like to merge the OpenID client implemented for .com into the > .org. I did take a look at the .com codebase, which should be located here: > http://subversion.amdatu.org/svn/amdatu/sandbox/angelos/bndtools_build/org.amdatu.openid > > Now I have the following questions & remarks, hoping that anyone can answer > these: > > · Is the code up to date? It seems that the OpenID code is not > actually used. The bundle exports the packages org.amdatu.openid.client and > org.amdatu.openid.server, but none of the classes contained by these packages > are actually used by any other bundle. I thought there was some OpenID > specific logic implemented in the login service and gadget but I simply can’t > find it. > · There is a lot of magic going on with the dependency on the > HttpService and dynamic servlet registration, no idea why. Servlets are > registered directly using the HttpService while it should be using the > whiteboard pattern. It seems that the only thing it actually does is > registering the OpenID callback servlet. What’s the fuzz about? > · A simple example actually using the OpenID client would help, I’m > not sure how I am supposed to use it and the code contains > obsolete/uncommented code. > > Regards, Ivo > > GX Software | Ivo Ladage-van Doorn | Product Architect | Wijchenseweg 111 | > 6538 SW Nijmegen | The Netherlands |T +31(0)24 - 388 82 61 | F +31(0)24 - 388 > 86 21 | [email protected] | www.gxsoftware.com > |twitter.com/GXSoftware > > _______________________________________________ > Amdatu-developers mailing list > [email protected] > http://lists.amdatu.org/mailman/listinfo/amdatu-developers
_______________________________________________ Amdatu-developers mailing list [email protected] http://lists.amdatu.org/mailman/listinfo/amdatu-developers
