[
http://jira.amdatu.org/jira/browse/AMDATUOPENSOCIAL-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11877#comment-11877
]
Ivo Ladage - van Doorn edited comment on AMDATUOPENSOCIAL-137 at 11/15/11 2:49
PM:
-----------------------------------------------------------------------------------
Did a code review and have the following remarks:
- In dashboard_multiple.html jquery.dashboard.min.js should be used instead of
jquery.dashboard.js
- jquery.dashboard.min should be generated and added to the patch
- In dashboard_multiple.html at line 133 a random start id is generated. Seems
to me that is used to give each dashboard a unique range of ids it can use for
its widgets. Although it is not very likely (but increases when many users use
it), with this approach id conflicts are possible so it needs another approach.
- Spelling error in dashboard_multiple.html line 211; 'hided' should be 'hidden'
- Fix the FIXME in jquery.dashboard.js
- In jquery.dashboard.js line 202 the index of a widget is set to 100 if it is
undefined. The method is invoked sometimes without the index, I guess this will
lead to id conflicts. Doesn't it?
Also did some testing and found the following issues:
- Small GUI error: if I press F5, at first the first dashboard selected, then
it switches to the current tab.
- Only when I have the first dashboard selected I can can add widgets properly,
in the other dashboards the widgets do not show up in the Add widget popup. To
reproduce, start clean, add dashboard, open add widget popup and select
'Another category'.
- Sometimes the widget titles (or content) is messed up. To reproduce, start
clean, add dashboard, remove the download plugin from the new dashboard, switch
to the first dashboard, add the download plugin widget. Now a widget is added
titled 'Download plugin', but it shows the content of the Examples plugin.
- In IE the order in which the widgets are presented on the dashboard is not
preserved (works in FF)
- Maximize/minimize does not work properly. To reproduce, start clean, add
dashboard, maximize a widget in the new dashboard, switch back the first
dashboard. It shows up empty.
was (Author: ivol):
Did a code review and have the following remarks:
- In dashboard_multiple.html jquery.dashboard.min.js should be used instead of
jquery.dashboard.js
- jquery.dashboard.min should be generated and added to the patch
- In dashboard_multiple.html at line 133 a random start id is generated. Seems
to me that is used to give each dashboard a unique range of ids it can use for
its widgets. Although it is not very likely, with this approach id conflicts
are possible so it needs another approach.
- Spelling error in dashboard_multiple.html line 211; 'hided' should be 'hidden'
- Fix the FIXME in jquery.dashboard.js
- In jquery.dashboard.js line 202 the index of a widget is set to 100 if it is
undefined. The method is invoked sometimes without the index, I guess this will
lead to id conflicts. Doesn't it?
Also did some testing and found the following issues:
- Small GUI error: if I press F5, at first the first dashboard selected, then
it switches to the current tab.
- Only when I have the first dashboard selected I can can add widgets properly,
in the other dashboards the widgets do not show up in the Add widget popup. To
reproduce, start clean, add dashboard, open add widget popup and select
'Another category'.
- Sometimes the widget titles (or content) is messed up. To reproduce, start
clean, add dashboard, remove the download plugin from the new dashboard, switch
to the first dashboard, add the download plugin widget. Now a widget is added
titled 'Download plugin', but it shows the content of the Examples plugin.
- In IE the order in which the widgets are presented on the dashboard is not
preserved (works in FF)
- Maximize/minimize does not work properly. To reproduce, start clean, add
dashboard, maximize a widget in the new dashboard, switch back the first
dashboard. It shows up empty.
> Improve multiple dashboard demo
> -------------------------------
>
> Key: AMDATUOPENSOCIAL-137
> URL: http://jira.amdatu.org/jira/browse/AMDATUOPENSOCIAL-137
> Project: Amdatu OpenSocial
> Issue Type: Improvement
> Reporter: Mark Machielsen
> Attachments: AMDATUOPENSOCIAL-137.patch, AMDATUOPENSOCIAL-137-v2.patch
>
>
> Currently the dashboard_multiple.html is not feature complete. Please add the
> following features:
> - add possibility to add dashboards
> - select the dashboard which is added
> - make sure the widget are added to the correct dashboard
> - store the dashboards and which widgets are on what tab in a cookie
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
