Jan Willem Janssen created AMDATU-517:
-----------------------------------------
Summary: Code review: web.dispatcher
Key: AMDATU-517
URL: http://jira.amdatu.org/jira/browse/AMDATU-517
Project: Amdatu
Issue Type: Bug
Components: Amdatu Web
Reporter: Jan Willem Janssen
Fix For: Backlog
My comments:
* general remark: the purpose of this bundle is not entirely clear. What
problem does it try to solve that isn't possible with the regular
ExtHttpService of Felix?
* HandlerServletContext appears to be tightly coupled to Felix' HTTP
implementation;
* HandlerServletContext has SuppressWarnings("deprecation") for some deprecated
methods?
* DispatchInterceptFilter tries to avoid duplicate initializations, but this is
still possible as no synchronization takes place in this method; aside that,
why is this necessary, as the Filter API clearly defines that it will call the
init method exactly once only?
* DispatchInterceptFilter has an unused method (getLogMessage);
* AbstractHandler is not thread-safe wrt its state member;
* DispatcherServiceImpl has redundant service-lifecycle methods & log
statements;
* DispatcherServiceImpl#start manually creates HandlerRegistry services which
is feeds OSGi services without respecting their life cycles, make them managed
components by DM should solve this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
