Jan Willem Janssen created AMDATU-520:
-----------------------------------------
Summary: Code review: web.jsp
Key: AMDATU-520
URL: http://jira.amdatu.org/jira/browse/AMDATU-520
Project: Amdatu
Issue Type: Improvement
Reporter: Jan Willem Janssen
My comments:
* why is this bundle made and not making use of PAX-Web JSP? The more code we
can reuse, the less code we need to maintain;
* JspSupport is a marker interface, please remove
* JasperClassLoader#getClassPathJars uses url.toExternalForm() twice without an
intermediary variable;
* ResourceProviderJspServlet declares unnecessary serialVersionUID, Servlet
isn't Serializable (anymore);
* I don't see any code instructing Jasper to be multi-tenant aware; this is
bound to fail.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
