[
http://jira.amdatu.org/jira/browse/AMDATU-514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12283#comment-12283
]
Matthijs Hendriks edited comment on AMDATU-514 at 1/26/12 4:28 PM:
-------------------------------------------------------------------
Both methods should be removed I think, rather than merging them. After having
the code changed as you proposed , the resulting method would be something like
{code}
public static void closeStreamSafely(Closeable c) throws IOException {
c.close();
}
{code}
which obviously is unnecessary overhead.
was (Author: matt):
Both method should be removed I think. After committing the changes you
say, the resulting method would be something like
{code}
public static void closeStreamSafely(Closeable c) throws IOException {
c.close();
}
{code}
which obviously is unnecessary overhead.
> Code review: libraries.fsstorage
> --------------------------------
>
> Key: AMDATU-514
> URL: http://jira.amdatu.org/jira/browse/AMDATU-514
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Core
> Reporter: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 2
>
>
> My comments:
> * FSStorageUtil#close{Input|Output}StreamsSafely: all InputStream- &
> OutputStream-derived classes implement the Closable interface; you can use
> that one to coerse both methods into a single method. The two arguments can
> also be coerced into a single argument, if you derive a ObjectInputStream
> from another stream calling close() on the ObjectInputStream will also close
> the contained stream (defined in the contract).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
