[ 
http://jira.amdatu.org/jira/browse/AMDATU-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12294#comment-12294
 ] 

Matthijs Hendriks commented on AMDATU-510:
------------------------------------------

It looks like that this bundle is made for no specific reason, as it is not 
used anywhere in the entire Amdatu project (except in the itest, but that 
doesn't count). I think its existence is useless.
                
> Code review: log.console
> ------------------------
>
>                 Key: AMDATU-510
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-510
>             Project: Amdatu
>          Issue Type: Improvement
>          Components: Amdatu Core
>            Reporter: Jan Willem Janssen
>              Labels: code_review
>             Fix For: Sprint 2
>
>
> My comments:
> * what purpose does this bundle serve? Isn't Felix' logging bundle or any 
> other OSGi implementation of LogService sufficient?
> * ConsoleLogHandler#updated isn't thread-safe and doesn't prevent concurrent 
> updates of the log-level;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to