[ 
http://jira.amdatu.org/jira/browse/AMDATU-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthijs Hendriks resolved AMDATU-511.
--------------------------------------

      Assignee: Bram de Kruijff
    Resolution: Fixed

To be moved to the attic.
                
> Code review: logforwarder.jdk
> -----------------------------
>
>                 Key: AMDATU-511
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-511
>             Project: Amdatu
>          Issue Type: Improvement
>          Components: Amdatu Core
>            Reporter: Jan Willem Janssen
>            Assignee: Bram de Kruijff
>              Labels: code_review
>             Fix For: Sprint 2
>
>
> My comments:
> * this implementation is faulty by design! It registers itself as only 
> LogHandler for all services that are registered, but it doesn't do anything 
> when services are removed. Also, the implementation totally ignores the fact 
> that when the logforwarder/handler service itself is removed/updated the old 
> implementation remains registered for existing services. The only purpose 
> this bundle serves is that it allows the standard JDK logging to be used, 
> while OSGi already provides a logging implementation by default. Why should 
> we bother to provide this bundle?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to