[ 
http://jira.amdatu.org/jira/browse/AMDATU-513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthijs Hendriks closed AMDATU-513.
------------------------------------

      Assignee: Bram de Kruijff
    Resolution: Duplicate

Already moved to the attic. See AMDATU-501
                
> Code review: useradminstore.fs
> ------------------------------
>
>                 Key: AMDATU-513
>                 URL: http://jira.amdatu.org/jira/browse/AMDATU-513
>             Project: Amdatu
>          Issue Type: Improvement
>          Components: Amdatu Core
>            Reporter: Jan Willem Janssen
>            Assignee: Bram de Kruijff
>              Labels: code_review
>             Fix For: Sprint 2
>
>
> My comments:
> * FSUserAdminStorageProvider has synchronized service lifecycle methods;
> * FSUserAdminStorageProvider stop method is redundant;
> * FSUserAdminStorageProvider: if m_storage must be available at all times, 
> why not provide it through a constructor arg?
> * Can this bundle not be coerced with the storage.blobstore bundle, or make 
> use of that bundle for its storage?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers

Reply via email to