[
http://jira.amdatu.org/jira/browse/AMDATU-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bram de Kruijff resolved AMDATU-523.
------------------------------------
Assignee: Jan Willem Janssen (was: Bram de Kruijff)
Resolution: Fixed
{quote}
why is this method of tenant-resolving present? It should only be used with
caution because it provides possible security issues;
{quote}
It was created as a poc and possible solution to situations where multiple
hostnames are not readily available such as itests and cloud deployments where
managing dns may be difficult. Having said so... it is not actually being used
anywhere in practice AFAIK.
{quote}
please fix the mentioned TODO for the tenantId parameter, is I can now pass in
something like 'tenant=*' for obtaining any tenant.
{quote}
I was implicitely fixed during refactoring to the new tenant mechanism. The
parameter is now check for NULL and then used for a map lookup only. Much
faster and possibly far less contention issues compared to the dynamic service
lookup strategy that was there before.
> Code review: web.tenantresolver.parameter
> -----------------------------------------
>
> Key: AMDATU-523
> URL: http://jira.amdatu.org/jira/browse/AMDATU-523
> Project: Amdatu
> Issue Type: Improvement
> Components: Amdatu Web
> Reporter: Jan Willem Janssen
> Assignee: Jan Willem Janssen
> Labels: code_review
> Fix For: Sprint 3
>
>
> My comments:
> * why is this method of tenant-resolving present? It should only be used with
> caution because it provides possible security issues;
> * please fix the mentioned TODO for the tenantId parameter, is I can now pass
> in something like 'tenant=*' for obtaining any tenant.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
