Marcel Offermans created AMDATU-557:
---------------------------------------
Summary: Remove special code for platform tenant
Key: AMDATU-557
URL: http://jira.amdatu.org/jira/browse/AMDATU-557
Project: Amdatu
Issue Type: Sub-task
Components: Amdatu Core
Reporter: Marcel Offermans
Fix For: Sprint 4
Right now, there is special code for the "platform" tenant, for example in the
MultiTenantBundleActivator:
{code}
String scope = determineScope(context);
if (createPlatformInstance(scope)) {
// For the _PLATFORM instance, we need to provide a custom filter &
PID...
manager.add(createComponent()
.setImplementation(new TenantAdapter() {
@Override
protected String getTenantFilter() {
return getPlatformTenantFilter();
}
@Override
protected String getTenantPID() {
return PID_VALUE_PLATFORM;
}
})
.add(createServiceDependency()
.setService(LogService.class)
.setRequired(false)
)
);
}
if (createTenantInstances(scope)) {
// For the individual tenants, we create an adapter that gets
called for each individually registered tenant...
manager.add(createAdapterService(Tenant.class, null)
.setImplementation(TenantAdapter.class)
.add(createServiceDependency()
.setService(LogService.class)
.setRequired(false)
)
);
}
{code}
Why don't we use an adapter for *every* tenant, also the platform tenant. That
way, we can just create an adapter. If you want a bundle that should only
create tenants for "normal" tenants, you can simply use a filter condition
instead of special casing it like this. That way, all tenants are equal again
in the sense that there is a Tenant service to represent its life cycle.
I'd like to review this together ASAP, as it's blocking for AMDATU-544.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://jira.amdatu.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
Amdatu-developers mailing list
[email protected]
http://lists.amdatu.org/mailman/listinfo/amdatu-developers
