noooooooo, we do!
it's a huge optimization.. to see if a specific file is animated, we have
a cache (which is always used unless specified otherwise) that keeps
whether a file is animated or not... if you remove that, then we'll ALWAYS
create an image, open the file, load it in memory, check if the image is
animated, then destroy it...
why did you remove that ? why did you think it wasn't used ?
can you please revert it back ?
On Thu, 27 Apr 2006 18:55:18 -0400, Karel Demeyer
<[EMAIL PROTECTED]> wrote:
Update of /cvsroot/amsn/msn
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12767
Modified Files:
picture.tcl sxml.tcl protocol.tcl
Log Message:
we dont use the animated_files_cache array, don't we ?
Index: sxml.tcl
===================================================================
RCS file: /cvsroot/amsn/msn/sxml.tcl,v
retrieving revision 1.16
retrieving revision 1.17
diff -C2 -d -r1.16 -r1.17
*** sxml.tcl 19 Apr 2006 18:08:53 -0000 1.16
--- sxml.tcl 27 Apr 2006 22:55:15 -0000 1.17
***************
*** 945,949 ****
set value [lindex $subkey 1]
if {$key == "#text" } {
! status_log "Found value : $value" blue
return $value
}
--- 945,949 ----
set value [lindex $subkey 1]
if {$key == "#text" } {
! # status_log "Found value : $value" blue
return $value
}
Index: picture.tcl
===================================================================
RCS file: /cvsroot/amsn/msn/picture.tcl,v
retrieving revision 1.24
retrieving revision 1.25
diff -C2 -d -r1.24 -r1.25
*** picture.tcl 19 Apr 2006 18:22:04 -0000 1.24
--- picture.tcl 27 Apr 2006 22:55:15 -0000 1.25
***************
*** 240,245 ****
#To verify if a picture is animated (1) or not (0)
! proc IsAnimated {file {use_cache 1}} {
! variable animated_files_cache
if { ![file exists $file] } {
--- 240,246 ----
#To verify if a picture is animated (1) or not (0)
! #} proc IsAnimated {file {use_cache 1}} {
! proc IsAnimated {file } {
! # variable animated_files_cache
if { ![file exists $file] } {
***************
*** 253,259 ****
}
! if {$use_cache && [info exists animated_files_cache($file)] } {
! return [set animated_files_cache($file)]
! }
if { [catch {::CxImage::IsAnimated $file} res] } {
--- 254,260 ----
}
! # if {$use_cache && [info exists animated_files_cache($file)] } {
! # return [set animated_files_cache($file)]
! # }
if { [catch {::CxImage::IsAnimated $file} res] } {
***************
*** 263,267 ****
error "Picture.tcl: Unable to read file $file \n$res"
} else {
! set animated_files_cache($file) $res
return $res
}
--- 264,268 ----
error "Picture.tcl: Unable to read file $file \n$res"
} else {
! # set animated_files_cache($file) $res
return $res
}
Index: protocol.tcl
===================================================================
RCS file: /cvsroot/amsn/msn/protocol.tcl,v
retrieving revision 1.816
retrieving revision 1.817
diff -C2 -d -r1.816 -r1.817
*** protocol.tcl 23 Apr 2006 16:04:23 -0000 1.816
--- protocol.tcl 27 Apr 2006 22:55:16 -0000 1.817
***************
*** 4808,4812 ****
}
default {
! status_log "Got unknown NS input!! --> [lindex $item
0]\n" red
return 0
}
--- 4808,4812 ----
}
default {
! status_log "Got unknown NS input!! --> [lindex $item 0]\n\t$item"
red
return 0
}
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-commits mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/amsn-commits
--
KaKaRoTo
-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/amsn-devel
