On Mon, 2006-06-26 at 18:07 -0400, Youness Alaoui wrote:
> On Mon, 26 Jun 2006 16:46:22 -0400, Vivia Nikolaidou <[EMAIL PROTECTED]>
> wrote:
>
> > On 6/26/06, Youness Alaoui <[EMAIL PROTECTED]> wrote:
> >> On Mon, 26 Jun 2006 07:44:04 -0400, Philippe Valembois - Phil
> >> <[EMAIL PROTECTED]> wrote:
> >>
> >> > Le Sunday 25 June 2006 21:55, Youness Alaoui a écrit:
> >> >> in here : http://amsn.sourceforge.net/forums/viewtopic.php?t=1205 you
> >> >> can
> >> >> find an image that doesn't work with TkCximage.. we plan on doing
> >> >> something to it ? Phil ? no more plans apart of the rewrite ? you're
> >> >> free
> >> >> to decide, but if some people use this image as DP and amsn crashes..
> >> >> for
> >> >> me, it's a critical issue...
> >> > Can't reproduce the error...
> >> > It only fails with it... The only thing I can do is to update libpng
> >> to
> >> > the
> >> > last version... I let you decide if I do it : it's ready to be
> >> > committed...
> >> > Phil
> >>
> >> Shouldn't we remove libpng and zlib, and all that crap from amsn SVN ?
> >> and
> >> leave it as a dependency ? add the dep in the configure and we're done ?
> >> just like what Sander did for FC5 ?
> >> I think it's the best way to do it... the only way it should be.
> >
> > Yes, unless they are patched? (I don't know). Then I guess we have to
> > do the same for tkdnd, but leave it optional.
>
>
> Huh ? what's your point with tkdnd ? tkdnd is not in SVN!!!
> I'm talking about amsn/utils/TkCximage/src/zlib
> amsn/utils/TkCximage/src/png amsn/utils/TkCximage/src/jpeg ... those are
> libraries we should find installed on the system and we shouldn't ship
> them with us...
> I just checked libjpeg, it hasn't changed so we're secure with it, but
> libpng has changed :
> http://www.libpng.org/pub/png/libpng.html
> look at the first red warning :
> "Versions 1.2.7, 1.2.6, 1.0.17, and 1.0.16 have a bug that will cause
> applications that strip the alpha channel (while reading a PNG) to crash.
> The bug is fixed in versions 1.2.8 and 1.0.18, which were released on 3
> December 2004."
> The one we have shipped with CxImage is version 1.2.7 (png.h) and the
> latest release is 1.2.10...
> and for zlib, we have 1.2.1 (zlib.h) while the latest is 1.2.3, and look
> at the first sentence in http://zlib.net
> "Version 1.2.3 eliminates potential security vulnerabilities in zlib 1.2.1
> and 1.2.2, so all users of those versions should upgrade immediately. The
> following important fixes are provided in zlib 1.2.3 over 1.2.1 and 1.2.2"
>
> Which means that we REALLY should make sure TkCximage depends on zlib
> 1.2.3+ and libpng 1.2.8+ (although 1.2.10 is preferred of course)
Or not, amsn won't crash, and if a user has outdated libs he should
worry about that himself. I don't think we should add extra complexity.
Attached I have the patch from my SRPM for the libs, easy enough but I
thought I would send it anyway.
>
> In the case of tkdnd... I still don't know what's the relation, we do ship
> it (who cares about the shipping), but I'm taking about what should be
> part of amsn's sources...
>
diff -ur amsn~/Makefile.in amsn/Makefile.in
--- amsn~/Makefile.in 2006-04-28 00:10:17.000000000 +0200
+++ amsn/Makefile.in 2006-05-20 10:37:16.000000000 +0200
@@ -50,7 +50,7 @@
LFS_FLAGS := -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
LIB_FLAGS := -I. -I$(capture_dir) -I$(capture_dir)/libng -I$(capture_dir)/structs
LIB_FLAGS += -I$(webcamsn_dir)/src -I$(tkcximage_dir)/src -I$(tkcximage_dir)/src/CxImage
-LIB_FLAGS += -I$(tkcximage_dir)/src/zlib -I$(tkcximage_dir)/src/png -I$(tkcximage_dir)/src/jpeg
+LIB_FLAGS += -Ipng -Ijpeg
LIBDIR := @LIBDIR@
@@ -100,7 +100,7 @@
CXXFLAGS += -fPIC
# libraries
-LDLIBS := @LDLIBS@
+LDLIBS := @LDLIBS@ -lpng -ljpeg
LDFLAGS := @LDFLAGS@
ifeq (@DEBUG@,no)
LDFLAGS += -s
@@ -224,9 +224,6 @@
include $(tkcximage_dir)/Rules.mk
include $(tkcximage_dir)/src/Rules.mk
include $(tkcximage_dir)/src/CxImage/Rules.mk
-include $(tkcximage_dir)/src/zlib/Rules.mk
-include $(tkcximage_dir)/src/png/Rules.mk
-include $(tkcximage_dir)/src/jpeg/Rules.mk
include $(tkcximage_dir)/src/Rules.mk
include $(webcamsn_dir)/Rules.mk
diff -ur amsn~/utils/TkCximage/src/CxImage/ximajpg.cpp amsn/utils/TkCximage/src/CxImage/ximajpg.cpp
--- amsn~/utils/TkCximage/src/CxImage/ximajpg.cpp 2006-04-13 15:22:27.000000000 +0200
+++ amsn/utils/TkCximage/src/CxImage/ximajpg.cpp 2006-05-18 23:03:20.000000000 +0200
@@ -9,7 +9,7 @@
#if CXIMAGE_SUPPORT_JPG
-#include "../jpeg/jmorecfg.h"
+#include <jmorecfg.h>
#include "ximaiter.h"
diff -ur amsn~/utils/TkCximage/src/CxImage/ximajpg.h amsn/utils/TkCximage/src/CxImage/ximajpg.h
--- amsn~/utils/TkCximage/src/CxImage/ximajpg.h 2006-04-13 15:22:27.000000000 +0200
+++ amsn/utils/TkCximage/src/CxImage/ximajpg.h 2006-05-19 10:12:38.000000000 +0200
@@ -29,8 +29,8 @@
#define CXIMAGEJPG_SUPPORT_EXIF 1
extern "C" {
- #include "../jpeg/jpeglib.h"
- #include "../jpeg/jerror.h"
+ #include <jpeglib.h>
+ #include <jerror.h>
}
class DLL_EXP CxImageJPG: public CxImage
diff -ur amsn~/utils/TkCximage/src/CxImage/ximapng.h amsn/utils/TkCximage/src/CxImage/ximapng.h
--- amsn~/utils/TkCximage/src/CxImage/ximapng.h 2006-04-13 15:22:27.000000000 +0200
+++ amsn/utils/TkCximage/src/CxImage/ximapng.h 2006-05-18 23:04:57.000000000 +0200
@@ -22,7 +22,7 @@
#if CXIMAGE_SUPPORT_PNG
extern "C" {
-#include "../png/png.h"
+#include <png.h>
}
long int inline btohl( long int dword ) {
diff -ur amsn~/utils/TkCximage/src/Rules.mk amsn/utils/TkCximage/src/Rules.mk
--- amsn~/utils/TkCximage/src/Rules.mk 2006-02-02 22:08:21.000000000 +0100
+++ amsn/utils/TkCximage/src/Rules.mk 2006-05-19 09:57:03.000000000 +0200
@@ -1,7 +1,5 @@
OBJS-TkCximage := $(tkcximage_dir)/src/TkCximage.cpp.o $(tkcximage_dir)/src/PhotoFormat.cpp.o \
- $(tkcximage_dir)/src/procs.cpp.o $(tkcximage_dir)/src/CxImage/libCxImage.a \
- $(tkcximage_dir)/src/jpeg/libjpeg.a $(tkcximage_dir)/src/png/libpng.a \
- $(tkcximage_dir)/src/zlib/libzlib.a
+ $(tkcximage_dir)/src/procs.cpp.o $(tkcximage_dir)/src/CxImage/libCxImage.a
ifeq ($(STATIC),yes)
OBJS-TkCximage += libstdc++.a
endif
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/amsn-devel
