humm.. you said "it works properly" which means ? I thought it meant "it means
properly for %W emoticons", but
then the rest of the mail suggests that it doesn't.. so I'm a little lost.. I
might try this later if I get the
time and see what you really meant.
good point about the editCustomEmoticon.
KKRT
On Fri, Dec 15, 2006 at 11:44:06AM +0100, Cristofaro Del Prete wrote:
> Oops, I forgot one thing:
>
> Youness Alaoui ha scritto:
> > While looking at this small portion of code in the diff, I also noticed
> > something else... we do a check for
> > whether the smiley is equal to %, in which case we insert %% (because the
> > 'bind' replaced %x with variable
> > values), but did we think of a smiley not being "%" but being "%W" instead
> > for example ? can you test something
> > like that ? and if it doesn't work (you get the window path inserted
> > instead of the "%W" smiley, then maybe it
> > would be wise to remove the if {[string match] } and replace it directly
> > with a bind "insert [string map { % %%
> > } $symbol] ...
> I checked and works properly, but the same fix should be done with $name
> in the editCustomEmotion calls; otherwise trying to edit a custom smiley
> whose name contains the % will generate an error.
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Amsn-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Amsn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/amsn-devel
