humm... no, we shouldn't remove those lines... are you sure ? can anyone else
confirm ?
I'll commit the job done so far...
KKRT
On Mon, Feb 12, 2007 at 11:58:00PM -0500, Youness Alaoui wrote:
> On Mon, Feb 12, 2007 at 11:55:09AM +0100, square87 wrote:
> > Good!
> > My code is always false :)
> > So the solution should be logic:
> > When we send an OIM we are in MessageSend that calls a proc that calls a
> > proc... etc... that calls PutLog
> > Then we return in MessageSend and we have:
> > if {[::config::getKey keep_logs]} {
> > ::log::PutLog $chatid $email $txt
> > }
> > So we log again and we see in log conversation:
> > timestamp user_login_that_we_have_sent_an_OIM: txt
> > So we not see our nick because in OIM::MessageSend there is:
> > set email $chatid
> > so we call (unnecessarily) PutLog with: [EMAIL PROTECTED]
> > [EMAIL PROTECTED]
> >
> > My code it's always false for this we don't call ::log::PutLog $chatid
> > $email $txt
> > So I Think that you can remove:
> > if {[::config::getKey keep_logs]} {
> > ::log::PutLog $chatid $email $txt
> > }
> >
> > I have tested without it and it works fine :)
> >
>
> ok.. I understood nothing, lol, but I think you want me to remove those
> lines, I'll do it and commit, you test
> and tell me if I committed wrong (I changed your diff so review my commit to
> see what should have been done
> instead, minor things...)
>
> > About lconvstartedOIM, I don't know if it is correct... :P but i try:
> > You have started sending or receiving offline messages on $1
> > We may not write:
> > You have started sending or receiving an offline conversation
> > Because the user is not online (or maybe is invisible....)
> >
> > Another thing I really hate this:
> > When I am chatting with a friend and the we add another friend we see in log
> > conversation:
> > $1 has entered into a conference on $2 {myuserlogin, friend1userlogin,
> > friend2userlogin}
> > But... the nice thing is when i am in a multichat where every minute for a
> > persone that leaves 2 persons are added... I see, in log conversation, this
> > hateful and unnecessary user_list...
> > The same for lprivtoconf, lconftopriv... Believe me it's very unnecessary,
> > because we already log when a user enters/leaves a convo
> > What do you think about to erase this _features_ ?
> > I may send you another diff with this change now (whit this OIM diff that
> > you are checking) or after you are checked OIM diffs.
> >
>
> nope, that's not needed, imagine a 1 hour long convo with 10 people, every 15
> minutes someone joins, there are 5
> messages per minute.. you look at the log and you see a sentence and want to
> know if X saw that line or not, you
> need to go back all the way up, read through those thousands of lines and
> keep a log (in your head) of who
> joined/left so you know who is there in the end, no, it's not good.. also,
> don't forget, you can join a
> conversation where there are already a couple of people in it, in that case,
> you don't know who's there because
> you never get a join/leave since you're the one who joined a multichat...
> leave it as is, no need for a change it will just bother the other users...
>
> > I believe that you are not logging your conversation :)
> > Thanks
>
> I do log my convos, I just never need to read them unless special cases...
> also, I never have multichat convos,
> so it's ok...
>
>
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Amsn-devel mailing list
> Amsn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/amsn-devel
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Amsn-devel mailing list
Amsn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/amsn-devel
