Hi Alex! Thanks for making the diff, and VGJ!! However, I'm _really_ *extremely* busy with other stuff at the lab these days (it's annoying when several top-priority urgent things pop up at the same time ☹) so... I am sorry... I probably can't review it until this weekend ☹
However, I do have some comments for you. The memleak might be because KKRT has msnp18 enabled. You can try that too. I especially want to know which revision started it. As for gui.tcl , you mean 600 out of 650 KB of your patch are just ... removed and readded whitespace??... Did you even know about the -w option in diff and -l option in patch? They are "ignore whitespace" options. So it would really be good to make an unpatched gui.tcl between current trunk and your patched gui.tcl, perform a diff -w -C3 (we do need three lines of context), and use that instead. (I know you did a lot of work already, but could you _please_ do that too? I don't think it would take more than 5 minutes :$) Once you're done with that, I'll review your patch. Note to everyone else: I don't want to merge without me reviewing it first, especially since I still remember more or less which commit was about what and I don't want to find out unwanted stuff in there (e.g. a bug accidentally brought back). TODO: the bug you reported: you may cancel a file you just sent but it will still be sent. (aka: if you misclick, you either quit your client or are mortified) Thanks again!!! Vivia PS: I think I overused something in this mail (... parentheses!) On Thu, Feb 10, 2011 at 23:48, Alexander Nestorov <alexander...@gmail.com> wrote: > Hi, I was working on merging vivia's p2p branch, and here is the result. It > has been a 7 days full-time work + 2 days of testing, and I haven't found > nothing unusual, but I'd like to get some feedback as I > wasn't able to reproduce the memleak, present until the very latest commits > in p2p branch, which KaKaRoTo got almost after every start. > > gui.tcl has a PITA, there is some weird indentation change between trunk and > p2p, so the patch is +600kb, and you'll probably see the same code being > removed and then readed. I didn't know if I should left that > or ignore it, so I decided to leave it. > Regards! > -- > alexandernst > > ------------------------------------------------------------------------------ > The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: > Pinpoint memory and threading errors before they happen. > Find and fix more than 250 security defects in the development cycle. > Locate bottlenecks in serial and parallel code that limit performance. > http://p.sf.net/sfu/intel-dev2devfeb > _______________________________________________ > Amsn-devel mailing list > Amsn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/amsn-devel > > ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Amsn-devel mailing list Amsn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/amsn-devel
