i wonder how many windows binaries we have in total... and what subset of them might actually benefit from being x86-64? might adb run faster with more registers? probably not? would aapt2? does anything else even have runtimes long enough that anyone *could* notice?
(the toolchain has been 64-bit for years, so nothing to be gained there.) On Wed, Jun 28, 2023, 13:01 enh <[email protected]> wrote: > but see the commit message for my zipalign fix, which points out that > switching to a 64-bit windows build doesn't help with this bug anyway. > > (this also means that windows64 is a wholly untested _variant_ of > 64-bitness --- my fear is that windows32 is safer because at least > windows32 is similar to 32-bit linux, whereas windows64 went with LLP64 > rather than unix's LP64. which is why a 64-bit build doesn't fix zipalign > in the same way it did for the unixes. at _some_ point our general 32-bit > support will have bitrotted to the extent that it might be worth taking > your chances with windows64, but that's probably closer to 2030.) > > On Wed, Jun 28, 2023 at 12:51 PM 'Dan Willemsen' via Android Building < > [email protected]> wrote: > >> There is build system support for 64-bit windows binaries, but it's not >> very well tested. A change like >> https://android-review.git.corp.google.com/c/platform/build/+/2645079 will >> produce a 64-bit zipalign.exe. >> >> On Wed, Jun 28, 2023 at 3:25 PM 'enh' via Android Building < >> [email protected]> wrote: >> >>> i suspect they mean "i want >>> https://android-review.googlesource.com/c/platform/build/+/2380864";, >>> the commit message for which mentions that there's no 64-bit Windows build >>> support (but you shouldn't need it either --- the OS doesn't support zip64, >>> so there'd be little use in being able to generate/modify zip64 files :-) ). >>> >>> On Wed, Jun 28, 2023 at 12:09 PM Fabien Sanglard < >>> [email protected]> wrote: >>> >>>> What do you mean by "32-bit limitation". Are you talking about zip64 >>>> file format? >>>> >>>> On Wed, Jun 28, 2023 at 11:53 AM John <[email protected]> wrote: >>>> >>>>> I manage to compile zipalign on Linux and it outputs as linux-x86 and >>>>> windows-x86. The question is how do I compile as 64-bit? I need 64-bit of >>>>> zipalign.exe to avoid 32-bit limitation >>>>> >>>>> -- >>>>> -- >>>>> You received this message because you are subscribed to the "Android >>>>> Building" mailing list. >>>>> To post to this group, send email to [email protected] >>>>> To unsubscribe from this group, send email to >>>>> [email protected] >>>>> For more options, visit this group at >>>>> http://groups.google.com/group/android-building?hl=en >>>>> >>>>> --- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Android Building" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web visit >>>>> https://groups.google.com/d/msgid/android-building/9afd65cc-c829-4adf-a81c-9030b7d8677en%40googlegroups.com >>>>> <https://groups.google.com/d/msgid/android-building/9afd65cc-c829-4adf-a81c-9030b7d8677en%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>>> -- >>>> You received this message because you are subscribed to the "Android >>>> Building" mailing list. >>>> To post to this group, send email to [email protected] >>>> To unsubscribe from this group, send email to >>>> [email protected] >>>> For more options, visit this group at >>>> http://groups.google.com/group/android-building?hl=en >>>> >>>> --- >>>> You received this message because you are subscribed to the Google >>>> Groups "Android Building" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/android-building/CALpSO9z3VCEtyeioWw5RdSNZ2Y1L-dABt3ukCJbEsfj6w_GCug%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/android-building/CALpSO9z3VCEtyeioWw5RdSNZ2Y1L-dABt3ukCJbEsfj6w_GCug%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> -- >>> You received this message because you are subscribed to the "Android >>> Building" mailing list. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected] >>> For more options, visit this group at >>> http://groups.google.com/group/android-building?hl=en >>> >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Android Building" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/android-building/CAJgzZop%3DyBRz%2BT5LpTciYsp%2BOtj7AKX6Tax-aOXK2C-NLyziyw%40mail.gmail.com >>> <https://groups.google.com/d/msgid/android-building/CAJgzZop%3DyBRz%2BT5LpTciYsp%2BOtj7AKX6Tax-aOXK2C-NLyziyw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> -- >> You received this message because you are subscribed to the "Android >> Building" mailing list. >> To post to this group, send email to [email protected] >> To unsubscribe from this group, send email to >> [email protected] >> For more options, visit this group at >> http://groups.google.com/group/android-building?hl=en >> >> --- >> You received this message because you are subscribed to the Google Groups >> "Android Building" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/android-building/CALQgHd%3DG0WEK%2BY9p-wgTxDCX-bmx2hSYZdHeHP7%2B88%3DYvNBKFg%40mail.gmail.com >> <https://groups.google.com/d/msgid/android-building/CALQgHd%3DG0WEK%2BY9p-wgTxDCX-bmx2hSYZdHeHP7%2B88%3DYvNBKFg%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- -- You received this message because you are subscribed to the "Android Building" mailing list. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/android-building?hl=en --- You received this message because you are subscribed to the Google Groups "Android Building" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/CAJgzZopUfFZeaog6Nq7vJh8hdY_3NER_eP1VqTqt%3DPDOs463Cw%40mail.gmail.com.
