rachana govilkar wrote: > > hey this is my ImageCapture.java......hope u [sic] get idea..... > > > package com.privacygram.activity; > > import android.content.Context; > import android.graphics.PixelFormat; > import android.hardware.Camera; > import android.hardware.Camera.Parameters; > import android.hardware.Camera.PictureCallback; > import android.hardware.Camera.ShutterCallback; > import android.view.SurfaceHolder; > import android.view.SurfaceView; > > public class ImageCapture extends SurfaceView{ > > SurfaceHolder previewHolder; > Why did you use package-private access for these two variables?
> Camera camera; > protected PictureCallback raw; > Why 'protected' access here? > protected ShutterCallback shutter; > protected PictureCallback postview; > protected PictureCallback jpeg; > > public ImageCapture(Context context) { > super(context); > // TODO Auto-generated constructor stub > Looks like this "TODO" was already done. > previewHolder = this.getHolder(); > > > > previewHolder.setType(SurfaceHolder.SURFACE_TYPE_PUSH_BUFFERS); > previewHolder.addCallback(surfaceHolderListener); > } > > SurfaceHolder.Callback surfaceHolderListener = new > Conventionally, for readability, one declares variables ahead of constructors and methods. > SurfaceHolder.Callback() > { > public void surfaceCreated(SurfaceHolder holder) > { > camera=Camera.open(); > try { > camera.setPreviewDisplay(previewHolder); > You need to use more conventional indentation and whitespace. > }catch (Exception E ){ } > Don't ignore exceptions, and except for very limited use cases, don't catch just 'Exception' but the specific exception type. > } > A blank line between methods improves readability. > public void surfaceDestroyed(SurfaceHolder arg0) > { > camera.stopPreview(); > camera.release(); > } > public void surfaceChanged(SurfaceHolder holder, int > format, > int width, int height) > { > Parameters params = camera.getParameters(); > params.setPreviewSize(width, height); > params.setPictureFormat(PixelFormat.JPEG); > camera.setParameters(params); > camera.startPreview(); > > camera.takePicture(shutter, raw, postview, > jpeg); > camera.stopPreview(); > camera.release(); > } > }; > } > > -- Lew -- You received this message because you are subscribed to the Google Groups "Android Developers" group. To post to this group, send email to android-developers@googlegroups.com To unsubscribe from this group, send email to android-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/android-developers?hl=en