Hi!

I just noticed a very bad example of using dialog fragments:

http://developer.android.com/guide/topics/ui/dialogs.html#PassingEvents

In the code snippet NoticeDialog holds a _static_ reference to
NoticeDialogListener. This interface is implemented by an Activity.
This can cause memory leaks (leaking Activity).
The correct solution should use the Activity reference from onAttach
just like here:
http://developer.android.com/guide/components/fragments.html#EventCallbacks

R

-- 
You received this message because you are subscribed to the Google
Groups "Android Developers" group.
To post to this group, send email to android-developers@googlegroups.com
To unsubscribe from this group, send email to
android-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/android-developers?hl=en

Reply via email to