Hi Ravi

I saw the change to query for format type in 10254/2 ; however that is
just a call to mDataSource->GetDataSourceFormatType which would return
PVMF_FORMAT_UNKNOWN for audio/video codecs. The format is recognized
in the Engine [ we know the right format in recognizecompleted(),
which is still before Sink components have been initialized by
playerdriver , however it is not updated back to the iDataSource ; and
hence the next query to mDataSource->GetDataSourceFormatType stil
returns PVMF_FORMAT_UNKNOWN. iDatasource does not have provide a way
to SetDataSourceFormatType without changing some interfaces.

manish

On Jun 12, 6:30 am, Ravi <yend...@pv.com> wrote:
> Ohh...looks like the code has been approved but not yet merged. It is
> waiting on a dependency to be merged.
>
> You can download the changes by:
> repo download platform/external/opencore 10254/2
> repo download platform/frameworks/base 10274/1
>
> Yes. It does provide the actual format type like mp3, mp4, etc.
>
> -Ravi
>
> On Jun 12, 4:58 am, manish <android.mm....@gmail.com> wrote:
>
> > Ravi
>
> > thanks, something like that would help. I could'nt find getFormatType
> > () in playerengine or driver either on master or donut tree.
> > Could you point me to the path.
> > Also does it provide format resolution down to information such as
> > PVMF_MP3 or is it at a higher level [ audio/video/text]
> > -manish
>
> > On Jun 10, 5:09 am, Ravi <yend...@pv.com> wrote:
>
> > > You can query the engine for the format type after the ->AddDataSource
> > > () command completes. So, for your usecase, you need to add code in
> > > playerdriver to use the new API that we introduced in there, called
> > > getFormatType(), to get the format type of the content used in
> > > "AddDataSource()". You would do this just before "AddDataSink()" so
> > > that you can make a decision on whichMIOto use.
>
> > > -Ravi
>
> > > On Jun 10, 4:04 am, manish <android.mm....@gmail.com> wrote:
>
> > > > Let me re-phrase the question.
> > > > How can we find out that file format is aac or mp3 before creating
> > > > audiosink node in playerdriver
> > > > PV engine seems to know File formats "after" source and sink nodes
> > > > have been created, a little too late. The source url for local
> > > > playback files is of type sharedfd://10.0.80239432 , doesn't  give
> > > > much idea of file extension really. How does PV parser know which
> > > > parser node to create ... it must scan the actual file for this data ,
> > > > as it seems mediaplayer/UI is passing a url like above to PV.
> > > > apologize if this is off topic, but some pointers would be
> > > > appreciated.
>
> > > > On Jun 9, 12:01 am, manish <android.mm....@gmail.com> wrote:
>
> > > > > Hi
>
> > > > > Need playerdriver to call customMIOfor certain Audio Format, while
> > > > > continuing to call AndroidAudioOutput for others. playerdriver does
> > > > > not really know the audio format type[ eg PVMF_MP3], so what would be
> > > > > the best way to achieve this ? also the GenericMIOinterface
> > > > > [ android_audio_mio.cpp] needs this information as well, to talk to
> > > > > appropriate threadsafe implementation. Currently, it is hardcoded to
> > > > > AndroidAudioOutput threadsafe implementation.
>
> > > > > thanks,
> > > > > M
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"android-framework" group.
To post to this group, send email to android-framework@googlegroups.com
To unsubscribe from this group, send email to 
android-framework+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/android-framework?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to