Looks like Change-Id If6efd11f5032141dadbfcd0b3215e89b464e5f35 (AOSP commit
aefc28a1b666f3e9b19eb5a8955e70297119f03d) is to blame.
As part of the removal of some performance checking code the conditional which
loaded the page as well as triggering a performance message was removed. The
specific section was;
diff --git a/core/java/android/webkit/BrowserFrame.java
b/core/java/android/webkit/BrowserFrame.java
index 2cc928f..388920c 100644 (file)
--- a/core/java/android/webkit/BrowserFrame.java
+++ b/core/java/android/webkit/BrowserFrame.java
@@ -872,11 +870,6 @@ class BrowserFrame extends Handler {
|| headers.containsKey("If-None-Match") ?
WebSettings.LOAD_NO_CACHE : cacheMode);
// Set referrer to current URL?
- if (!loader.executeLoad()) {
- checker.responseAlert("startLoadingResource fail");
- }
- checker.responseAlert("startLoadingResource succeed");
-
return !synchronous ? loadListener : null;
}
So adding back in the loader.executeLoad() with the following patch will, as
you've already pointed out, fix things;
diff --git a/core/java/android/webkit/BrowserFrame.java b/core/java/android/webk
index c194559..dfa8aa5 100644
--- a/core/java/android/webkit/BrowserFrame.java
+++ b/core/java/android/webkit/BrowserFrame.java
@@ -869,6 +869,8 @@ class BrowserFrame extends Handler {
loader.setCacheMode(headers.containsKey("If-Modified-Since")
|| headers.containsKey("If-None-Match") ?
WebSettings.LOAD_NO_CACHE : cacheMode);
+ // Load the page
+ loader.executeLoad();
// Set referrer to current URL?
return !synchronous ? loadListener : null;
}
Al.
--
T: @alsutton W: www.funkyandroid.com
The views expressed in this email are those of the author and not necessarily
those of Funky Android Limited, it's associates, or it's subsidiaries.
On 26 Dec 2011, at 22:17, Daniel Fages wrote:
> Hello,
> I'm working on building AOSP for VirtualBox.
> When upgrading from 4.0.1 to 4.0.3, the Browser and the WebView
> component don't work anymore - HTML pages are just loading and loading
> without anything showing up...
> After some hours studying the diff between the 2 versions, I realized
> that some code remove between 4.0.1 and 4.0.3 was responsible for
> this : in /frameworks/base/core/java/android/webkit/BrowserFrame.java
> at line 875 the call to loader.executeLoad() has been removed and the
> page is never loaded..
>
> After puting back the loader.executeLoad() call in my 4.0.3 source
> code, everything works fine.
>
> Has anyone else seen this ?
>
> Best regards,
> Dan.
>
> --
> unsubscribe: android-porting+unsubscr...@googlegroups.com
> website: http://groups.google.com/group/android-porting
--
unsubscribe: android-porting+unsubscr...@googlegroups.com
website: http://groups.google.com/group/android-porting
