Hi Sebastian, just had a look at your patch because I wanted to do some refactoring in V3.0 and thought, I could loosen the dependency to Velocity in that step.
I have seen that you abstracted away Velocity and Freemarker behind an interface (ITemplateEngine) and an abstract class (TemplateDriver) and that you have two classes per concrete scripting engine (VelocityDriver and VelocityEngine, FreemarkerDriver and FreemarkerEngine). Some comment says that this follows the mediator pattern. Why didn't you use the adapter pattern, using one abstract interface (ScriptingEngineAdapter) and two concrete adapter classes, VelocityAdapter and FreemarkerAdapter? Moreover, in VelocityEngine, there is a tricky part where you construct a VelocityDriver object using reflection. Why is all this so complex? Cheers... Matthias --- Matthias Bohlen "Consulting that helps project teams to succeed..." http://www.mbohlen.de/ openMDA - the conference about Model Driven Architecture September 15-17, Köln, Germany http://www.openmda.de ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01 _______________________________________________ Andromda-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/andromda-devel
