Chad,

 

You once committed a change with this comment:

 

“Cleanup some javadocs and also override StateVertexFacadeLogicImpls

getName() method so that it enforces java class name as well.  Otherwise

its implossible for use case names to match the final state name.  We

may need to think more about this.”

 

Thanks for this fix dude! I don’t know how you managed to understand bpm4struts that well, but I’m really impressed.

 

Anyway, I was thinking maybe to rethink the getName() methods we have now … I decided once to have them converted to Java conventions automatically, but I am not so sure if this is a good thing.. I mean, what if the user wants to generate C++ code with his templates ? I think now that my decision was made a little quickly

 

There also are some possible side-effects that might complicate things at a certain point, and my guess is it is pretty realistic to assume that it will be less convenient to change/fix at that point.

 

Since nothing depends on this “feature” yet, maybe we could consider rolling it back to the default behavior ? It would mean we need to remove the getName() in classifier, statevertex, etc…

 

What do you think ?

 

-- Wouter

 

Reply via email to