[ http://jira.andromda.org/browse/JAVA-34?page=comments#action_15203 ]
Bob Fields commented on JAVA-34: -------------------------------- Detailed list of changes with line numbers, for review, since the diff shows everything as different due to whitespace: Generally: Removed java.lang. from fully qualified names (not needed for compilation) Generally: Added imports where necessary, changed fully qualified names: Serializable, java.util.ArrayList etc, java.io.ObjectStreamException 20: set $valuesTemplateType = <String, $enumeration.name> if enumeration.fullyQualifiedName is blank 51: Default to String if enumeration.literalType is empty 58-62: Use valueIn instead of value, and qualify with this. (Avoid compiler warning with name masking) 84: Added javadoc for return value 86: Added from operation signature to include literal value, if fromSignature is empty (this apparently was not fixed in UML2 Enumeration Facade) 92, : VALUES instead of values for static final attribute (Java naming conventions) 111: Added javadoc for param and return 119: Changed == to .equals() for object equality check 187, 192: Changed javadoc <p/> to <p> (invalid tag) 217-220: Qualified variables with $enumeration.name - In case we inherit from another enumeration > Invalid code generated for enumeration literals > ----------------------------------------------- > > Key: JAVA-34 > URL: http://jira.andromda.org/browse/JAVA-34 > Project: Java Cartridge > Type: Bug > Environment: MagicDraw 12.1 > Reporter: Matthias Bohlen > Assignee: Matthias Bohlen > Attachments: Enumeration.vsl, Enumeration.vsl.patch > > When I model an enumeration with true enumeration literals (not attributes > but true literals), Enumeration.vsl is expanded and generates this statement > which does not compile: > public static final ItemState AVAILABLE = new > ItemState($literal.enumerationValue); > This is because the EnumerationLiteralFacadeLogicImpl class does not have a > method handleGetEnumerationValue(). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.andromda.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
