Hey, Cheers Sorry didn't explain properly. Updating from jasmine 2.1.1 to 2.2.1 fixes the issue. Where the version is defined in protractors package.json
On Thursday, 30 April 2015 11:06:09 UTC+1, Pawel Kozlowski wrote: > > Hi! > > You should send a pull request to a concerned module, not to the > angular itself in this case. > > Cheers, > Pawel > > On Thu, Apr 30, 2015 at 12:01 PM, <[email protected] <javascript:>> > wrote: > > What are the guidelines and rules for updating node_modules. > > > > I have found an issue that is fixed by updating the version of jasmine > that > > a dependency of protractor. > > > > What are the guidelines / rules I should follow for creating a pull > request > > with this change? > > > > Obviously the contributing rules are defined here: > > https://github.com/angular/protractor/blob/master/CONTRIBUTING.md > > > > Are there specific rules for the case that I am talking about? > > > > Cheers > > > > -- > > You received this message because you are subscribed to the Google > Groups > > "AngularJS" group. > > To unsubscribe from this group and stop receiving emails from it, send > an > > email to [email protected] <javascript:>. > > To post to this group, send email to [email protected] > <javascript:>. > > Visit this group at http://groups.google.com/group/angular. > > For more options, visit https://groups.google.com/d/optout. > > > > -- > AngularJS book: > http://www.packtpub.com/angularjs-web-application-development/book > Looking for bootstrap-based widget library for AngularJS? > http://angular-ui.github.com/bootstrap/ > -- You received this message because you are subscribed to the Google Groups "AngularJS" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/angular. For more options, visit https://groups.google.com/d/optout.
