Commit where this problem starts:
29d41bb789383c3ff59269b28877ea0f270f5861  however, I don't think this
is a bad commit.  I think it's just exposing a bug elsewhere.

Where that elsewhere is... it looks to me like the json library in
python2.6's stdlib has a bug that's causing this to fail.  I haven't
found a bug report in python or simplejson's issue trackers that
points out where they may have fixed this specifically. I have found a
commit where upstream python synced changes from simplejson-2.0.9
(python2.6's json looks to have been based on simplejson 1.9).
Delving into simplejson's code, I found that this commit fixed this
issue: 
https://github.com/simplejson/simplejson/commit/2afcca8635bb0adce45bcff7c069f320c82eb9f8#diff-436b24490ceb0883d559805a466865c5

That appears to have been part of an optimization effort rather than a bugfix...

Where does that leave us....  To work around your bug on EPEL6, I
think I can get the EPEL package to include a small patch to prefer
simplejson over json in  filter_plugin/core.py.  Not sure if I can
also have ansible in epel6 start Requiring python-simplejson but even
if I can't you can simply install it on your RHEL6 hosts.  Between
those two things, that should fix this particular issue for you.

For upstream ansible code, the answer isn't quite so simple.  I
haven't tracked down precisely what it is about your test that's
breaking (other than it's to_nice_json) and we probably don't want to
force everyone to install simplejson.  So I'm not sure what precisely
we want to do.  Perhaps, something like this in to_nice_json():

if sys.version_info < (2, 7):
    try:
        import simplejson as json
    except ImportError:
        return to_json()
        # Or raise an informative error?

I'll talk to a few other people about what they'd like the fallback
code to do in this case.

-Toshio

On Sun, Jan 11, 2015 at 1:45 PM, Toshio Kuratomi <tkurat...@ansible.com> wrote:
> Mmmm.... one big correction -- It does not work with current devel (I
> was testing with a *really* old checkout before).  So there's another,
> unaddressed bug here...
>
> -Toshio
>
> On Sun, Jan 11, 2015 at 1:33 PM, Toshio Kuratomi <tkurat...@ansible.com> 
> wrote:
>> Had a chance to try using your repo on CentOS6 (with python-2.6.6) and
>> I can confirm that ansible-1.8.2 has this problem but ansible devel
>> does not.  Going to try to track down the commit that causes this and
>> whether it's easy to isolate the patch to fix it.
>>
>> -Toshio
>>
>> On Fri, Jan 9, 2015 at 1:11 AM, James Morgan <jamesdmor...@gmail.com> wrote:
>>> Dev environments use Python 2.6.6
>>> Docket has Python 2.7.3
>>>
>>> That could well be the root of my issue and why you are unable to reproduce
>>> and why I can't on docker
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "Ansible Project" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to ansible-project+unsubscr...@googlegroups.com.
>>> To post to this group, send email to ansible-project@googlegroups.com.
>>> To view this discussion on the web visit
>>> https://groups.google.com/d/msgid/ansible-project/eea7fc53-05d4-4853-ad81-20a8bc67e7fc%40googlegroups.com.
>>>
>>> For more options, visit https://groups.google.com/d/optout.

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to ansible-project+unsubscr...@googlegroups.com.
To post to this group, send email to ansible-project@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/CAG9juEoS0Hc1aJ5QzRLbVnnBQRzqxcc-yaDZ_jhCDZCc%2Be5xTQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to