Hi Matt, We had a lot of requests for pbrun support from some users and customers, and Brian had already done a lot of work on it for the 1.9 release before we had originally changed course and decided to make it a 2.0 feature. However, we decided to make it a stretch goal for 1.9, so users who wanted it would not have to wait until late May or early June when 2.0 would go live. Additionally, since we're now doing the release candidates, we felt this would help weed out any bugs. We've also had a couple of reports of bugs already, so we'll be doing an rc2 next Tuesday and there's still plenty of time to test things out. This also tells us that the RC process is working as we intended it to - we do not expect every rc1 to be perfect and consider it an alpha release.
When reviewing the patch, I felt about 80% of it was either a cut/paste replacement of the existing code to use the new variables names, or whitespace cleanup. So despite the size of the patch, it wasn't quite as impacting as an 800+ line code change might look at first. Thanks! James Cammarata Director, Ansible Core Engineering github: jimi-c On Wed, Mar 11, 2015 at 9:10 AM, Matt Martz <m...@sivel.net> wrote: > Accidentally sent this off list, so let's try again... > > Unrelated, but should the new escalation code really be included in 1.9? > I'd think for something with such potentially impactful changes that it > should bake for longer than an RC before release. > > > > > On Wednesday, March 11, 2015, Serge van Ginderachter < > se...@vanginderachter.be> wrote: > >> Am I doing something wrong? >> >> >> [(rmts/nsbl/stbl-1.9)] serge@goldorak:~/src/ansible/ansible$ git co >> v1.9.0-0.1.rc1 >> HEAD is now at bce4bb2... preliminary privlege escalation unification + >> pbrun - .... >> [(rmts/nsbl/stbl-1.9)] serge@goldorak:~/src/ansible/ansible$ git >> submodule update >> [(rmts/nsbl/stbl-1.9)] serge@goldorak:~/src/ansible/ansible$ make tests >> ...... >> test_with_tag (TestDocker.DockerSplitImageTagTestCase) ... ok >> test_with_tag_and_org_name (TestDocker.DockerSplitImageTagTestCase) ... ok >> >> ====================================================================== >> FAIL: verify the synchronize action plugin unsets and then sets sudo >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File "/home/serge/src/ansible/ansible/test/units/TestSynchronize.py", >> line 102, in test_synchronize_action_sudo >> 'rsync_path':'"sudo rsync"'}, "wrong args used" >> AssertionError: wrong args used >> >> >> ---------------------------------------------------------------------- >> Ran 231 tests in 9.084s >> >> FAILED (failures=1) >> make: *** [tests] Error 1 >> >> >> >> >> -------------------------------------------------------------------------------------------------------------------------------------------- >> >> Building the deb works, but at install time: >> >> >> [(rmts/nsbl/stbl-1.9)] serge@goldorak:~/src/ansible/ansible$ sudo dpkg >> -i deb-build/unstable/ansible_1.9-0.1.rc1ppa~unstable_all.deb >> (Reading database ... 316161 files and directories currently installed.) >> Preparing to unpack .../ansible_1.9-0.1.rc1ppa~unstable_all.deb ... >> Unpacking ansible (1.9-0.1.rc1ppa~unstable) over >> (1.9-0.1.rc1ppa~unstable) ... >> Setting up ansible (1.9-0.1.rc1ppa~unstable) ... >> Processing triggers for python-support (1.0.15) ... >> Compiling >> /usr/lib/pymodules/python2.7/ansible/runner/connection_plugins/paramiko_ssh.py >> ... >> File >> "/usr/lib/pymodules/python2.7/ansible/runner/connection_plugins/paramiko_ssh.py", >> line 249 >> utils.su_prompts.check_su_prompt(become_output)): >> >> SyntaxError: invalid syntax >> >> Processing triggers for man-db (2.6.7.1-1ubuntu1) ... >> >> >> See https://github.com/ansible/ansible/pull/10428 >> The travis test build fails, but that seems a problem with travis >> itself... >> >> >> Serge >> >> On 11 March 2015 at 00:08, James Cammarata <jcammar...@ansible.com> >> wrote: >> >>> Hi all, we've just tagged the rc1 release for 1.9, which you can test as >>> follows: >>> >>> To test from source, simply clone the git repository (if you haven't >>> already) and do the following: >>> >>> $ git checkout v1.9.0-0.1.rc1 >>> $ . hacking/env-setup >>> >>> After which time you can run ansible and ansible-playbook like normal. >>> If you're not familiar with the hacking/env-setup script, please refer to >>> the documentation here: >>> >>> http://docs.ansible.com/intro_installation.html#running-from-source >>> >>> To make an RPM or DEB with which to test, do the following: >>> >>> $ git checkout v1.9.0-0.1.rc1 >>> >>> # for RPMs >>> $ OFFICIAL=yes make rpm >>> # for DEBs >>> $ OFFICIAL=yes make deb >>> >>> If you discover any errors related to this release candidate, please >>> open a Github issue and be sure to mention you're testing against the >>> release candidate. >>> >>> Thanks! >>> >>> James Cammarata >>> Director, Ansible Core Engineering >>> github: jimi-c >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Ansible Development" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to ansible-devel+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ansible Development" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to ansible-devel+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > > -- > Matt Martz > @sivel > sivel.net > > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to ansible-project+unsubscr...@googlegroups.com. To post to this group, send email to ansible-project@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CAMFyvFixgL%3DZD8za96M%2BqnBcrCDXaL-4j%3Df6Nmj_SEQn-FmFaw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
