I'm happy to see the 'real' solution happening. Meanwhile we can live with a local patch to get things up and running. IMHO Main should just do the parsing of the parameters and fill that into Project; everything else (e.g. configuring the project) should be done within Project. The logging is a bit tricky because to set user properties Main calls Project.setUserProperty() which logs the property, and that shouldn't happen before fireBuildStarted() :-/. I think the solution to that problem would be to let these methods not log anymore, and log the 'base' project state in a modified executeTarget(s) method.
The calculation of target lists should be moved from Main to Project, too. Wolf > -----Original Message----- > From: Stefan Bodewig [mailto:[EMAIL PROTECTED] > Sent: Tuesday, November 07, 2000 3:32 PM > To: [EMAIL PROTECTED] > Subject: Re: Capturing ANT Output > > > >>>>> "SW" == Siberski, Wolf <[EMAIL PROTECTED]> writes: > > SW> Main calls Project.fireBuildStarted() when starting the build and > SW> Project.fireBuildFinished() at the end. We would like to do the > SW> same to trigger the BuildListeners, but unfortunately both > SW> methods are protected. Could You make these methods public? > > As a workaround, yes. In general I agree with your and Simeon's > opinion that Project should be responsible for firing these Events > itself (and yes, I don't think the separation of Project/Main is very > well defined). > > Maybe we can find a better way to move the fireBuildStarted/Finished > methods quickly so we don't need to make those methods public at > all. I'm going to look into it this evening. > > Stefan >
