Jon, It appears that you have reformatted the files a little here - I guess that was intentional. Rather than wading through that, I'll assume you committed the patch exactly as Josh submitted it.
I'm not that keen on this. The patch lets you specify a token attribute at the target level. What does copy filtering have to do with a target, really? As well, the target just sets the value on the project object. I think the whole copy functionality should be refactored out of Project, perhaps into <copy> Why not make this token attribute an attribute of copy, along with a nested filter element, so filtering can become more explicit in operation. Something like <copy tokendelimiter="%" ...> <filter token="year" value="2000"/> </copy> Of course, we would still support the current "global" filters implicitly. If we let this go ahead now, we create a backward compatibility issue later on. Thoughts? Conor -- Conor MacNeill [EMAIL PROTECTED] Cortex eBusiness http://www.cortexebusiness.com.au > -----Original Message----- > From: Jon Stevens [mailto:[EMAIL PROTECTED] > Sent: Thursday, 18 January 2001 12:45 > To: [EMAIL PROTECTED] > Subject: Re: [PATCH] Re: other tokens > > > on 1/17/01 5:20 PM, "Josh Lucas" <[EMAIL PROTECTED]> wrote: > > > here ya go... > > I just checked this in. could you also please update the index.html? > > thx. > > -jon > > -- > Honk if you love peace and quiet. > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
