Jon Skeet <[EMAIL PROTECTED]> wrote:

>> Then don't do that ;-), we just need a patch against the current
>> CVS version to include it in Ant 1.4.
> 
> Ah, but I'm using 1.3 at the moment, so it's easiest to develop it
> against that :)
> 
> (Hopefully the difference shouldn't be too big, however.)

The main changes are on the import lines.

>> > Right. My initial thought was to have a protected
>> > getUpdateZipFileSet method and override it in subclasses
>> 
>> But please make this optional.
> 
> I'm not sure what you mean by optional in this case... the user
> wouldn't have to specify anything in this case - it would all be
> hard-coded in the relevant classes (with zip just returning an
> "include everything" ZipFileSet).

This is what I mean - make it possible for the user to say "I want the
include everything fileset, even if I said <jar> and not <zip>".

But start out with whatever seems most appropriate to you.

Stefan

Reply via email to