> -----Original Message-----
> From: Julian M. Savage [mailto:[EMAIL PROTECTED]

> The JUnit task supports a timeout feature, but it doesn't give any
> indication to the user that a timeout caused a test failure. 
> I forgot I'd
> put a timeout in, and this cost me a bit of time when I 
> couldn't determine
> immediately why the test failed. The code was mostly written 
> to do this, but
> doesn't actually give a message to the user. I guess that the 
> authors wanted
> to go back and do it right, but I'm submitting this very 
> simple patch on the
> chance it might save someone a bit of time.
[...]

You're right. When I refactored the task, I also added a property to the
watchdog so that I could check if it was used to kill the process but never
implemented it fully. This is because I was wondering what strategy to
choose and did not want to make too many changes at once in the behavior.
Considering it now, it was probably not my best decision. :)

Thanks a lot for taking the time to do it.

-- 
 St�phane Bailliez 
 Software Engineer, Paris - France 
 iMediation - http://www.imediation.com 
 Disclaimer: All the opinions expressed above are mine and not those from my
company. 

Reply via email to