OK, I've fixed the null pointer bug, run all the existing JUnit tests,
rewritten the feature to allow multiple nested <flags ...> tags.
Since this mailing list has quite a lag, I'm going to submit my new
patch directly to bugzilla.
Thanks!
-Steve-
Stephen Anderson wrote:
>
> There was also a bug in the code I sent that causes a null pointer
> exception if the new flag isn't present. Perhaps I should've started
> with asking if there's a FAQ for newbie ANT code submitters.
>
> -Steve-
>
> Stephen Anderson wrote:
> >
> > Hmmm,
> >
> > I just realized that I implemented this in a way that doesn't allow
> > multiple <flags compiler="jikes" args="+Z"/> like nested tags.
> >
> > I'll fix it, and submit a new patch.
> >
> > My questions about how to submit this, and requests for feedback still
> > stand though.
> >
> > Shoot! ;)
> > -Steve-
> >
> > Stephen Anderson wrote:
> > >
> > > Hi all,
> > >
> > > Diane's was the culminating suggestion in answer to my request to set
> > > Jikes to stop on warnings as if they were errors. The original thread
> > > was on ant-user.
> > >
> > > I've coded this up and attached the cvs diff -u output. Can we add this
> > > to ant? Is there more work I need to do to bring it up to snuff?
> > > Should I have posted this directly to bugzilla, instead?
> > >
> > > This is my first real open source contribution, so I'm really looking
> > > forward to your feedback, be it positive, or negative.
> > >
> > > Thanks!
> > > -Steve-
> > >
> > > PS: Ant rocks. I'm never going back.
> > >
> > > Diane Holt wrote:
> > > >
> > > > --- Conor MacNeill <[EMAIL PROTECTED]> wrote:
> > > > > > But maybe we've simply reached the point to introduce
> > > > > >
> > > > > > <javac additionalArgs="..." />
> > > > >
> > > > > I think this capability should probably be there but it does have some
> > > > > problems. Such a build file will fail with a different compiler since
> > > > > the compiler adapter cannot know whether the arg applies to its
> > > > > particular compiler (unless it is really smart about it).
> > > > >
> > > > > It seems a balance between a mega-interface and non-portable build
> > > > > files. Thoughts about where that balance lies?
> > > >
> > > > How about a nested <flags> element that takes a "compiler" and "args"
> > > > attribute, and only uses those that are for the compiler currently being
> > > > used? For example:
> > > >
> > > > <flags compiler="jikes" args="+Z"/>
> > > > <flags compiler="modern" args="-g:lines"/>
> > > >
> > > > Either that, or I could see people specifying the value of the
> > > > "additionalArgs" attribute as a property (probably use <condition> to
> > > > test
> > > > ${build.compiler} and set [a default value for] the property for
> > > > "additionalArgs" accordingly).
> > > >
> > > > Diane
> > > >
> > > > =====
> > > > ([EMAIL PROTECTED])
> > > >
> > > > __________________________________________________
> > > > Do You Yahoo!?
> > > > Make a great connection at Yahoo! Personals.
> > > > http://personals.yahoo.com
> > >
> > > ------------------------------------------------------------------------
> > > M src/main/org/apache/tools/ant/taskdefs/Javac.java
> > > M
> > > src/main/org/apache/tools/ant/taskdefs/compilers/DefaultCompilerAdapter.java
> > > M src/main/org/apache/tools/ant/taskdefs/compilers/Gcj.java
> > > M src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java
> > > M src/main/org/apache/tools/ant/taskdefs/compilers/Jvc.java
> > > M src/main/org/apache/tools/ant/taskdefs/compilers/Kjc.java
