On Fri, 9 Nov 2001, Conor MacNeill wrote:
> Holger Engels wrote:
>
> >
> > These patches along with additional classes introduce / contain:
> >
> > o a fileset like depset for use in jar-/zip-task
>
>
> Holger,
>
> I have committed the depset code with some modifications. This is based
> on your original depset.jar file. I haven't checked for any updates in
> this latest set.
>
Cool! I'll check, if there where updates .. I don't remember.
> I made the following changes
>
> 1. I moved the classes into two separate packages - one for the type
> itself and scanner and one for the Dependencies utility classes since
> other tasks will depend on those. The packages also help with
> conditional compilation in the Ant build file.
>
ok
> 2. I renamed the class ClassfileSet rather than depset since I thought
> that name was a bit clearer
name is better. It makes clear, that it is only applicable to java class
files.
> 3. I added Apache copyright to the classes that did not already contain
> one. Please indicate your agreement to that.
ok
> 4. I removed tabs and added a few {} blocks around for statements and if
> statements
sorry for the tabs .. should change my emacs configuration ..
>
> Also, I would like to make some suggestions. I tested with this setup
> just on Ant's own code
>
> <classfileset dir="build/classes"
> baseclass="build/classes/org/apache/tools/ant/Main.class" id="classes"/>
>
> <target name="main">
> <mkdir dir="deptest"/>
> <copy todir="deptest">
> <fileset refid="classes"/>
> </copy>
> </target>
>
> Now, I would prefer that to work something like this
>
>
> <classfileset dir="build/classes" id="classes">
> <root class="org.apache.tools.ant.Main"/>
> <root class="org.apache.tools.ant.Project"/>
> </classfileset>
>
> In other words, the classes should be expressed in the Java namespace
> rather than the file namespace and I should be able to specify multiple
> roots for dependency searches. What do you think?
I thought of that, too. Actually I had to use rather ugly code, to achieve
this, recently. I'll work on that, soon.
> I haven't looked at the Zip.java changes yet but when using refids as
> above, they may not be necessary.
+ public void addDepset(DepSet set) {
+ filesets.addElement(set);
+ }
Thanks,
Holger
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
