On Fri, 21 Dec 2001 15:03, Steve Loughran wrote:
> I'm going to put my hand up as the naming police for ant1.9, and I want to
> make an early start with ant1.5, looking at the
> {zip,tar,jar,gzip,bzip} tasks, giving them a consistent use of srcFile,
> srcDir, destFile and destDir. This is for consistency, learning and easier
> cut and
> paste work.

Wooohoooo! 

> 1. Peter made zip, war and jar consistent by adding the file attribute
> after the 1.4.1 release to spec the output file. However, this attribute is
> often used for source files as well as dest files.
>
> I would like to replace this with the 'destFile' attribute; leaving the old
> warfile, jarfile stuff in there as deprecated, adding deprecation to the
> file attr, and pulling the file attribute from the docs. Only people using
> CVS version of ant1.5 will have encountered this attribute.

+1 but could you also deprecate the file attribute because theres a few 
people who are using it 

> 2. gzip, bzip2 need srcFile and destFile attributes, and should add
> dependency testing to not create the dest if it is up to date. Right
> now their docs talk about tofile as the name of the output file, but the
> current source
> uses zipfile as the source file which is another little consistency issue.
> I have
> a patch for the docs there.

+1

> 3. Unjar/Untar/Unwar/Unzip can take the srcFile and destDir attrs as
> aliases for their existing stuff

+1

> 4. Gunzip. Bunzip2 can take srcFile easily. Its dest attribute can be
> either a file or a directory, with different behavior in each case. I'd
> like to add explicit destDir and destFile attributes and behaviour, which
> would be trickier and need more tests.

+1

-- 
Cheers,

Pete

--------------------------------------------------
you've made a dangerous leap right over common 
sense, like some kind of metaphysical Evil Knievel
--------------------------------------------------

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to