From: "Steve Loughran" <[EMAIL PROTECTED]> > What it did say was that I had experimentally added srcfile and destfile > attrs into zip, war, jar and ear, as part of the unification of attribute > names which I proposed a few weeks back, and kind of led to this whole > thing.
I will say it did ;-) > But I havent committed any of that, as I was testing to see how it worked, > and waiting for everyone to come back from xmas. Looks like half the changes > are moot now; I will bind the attributes to File instead. Sorry about messing up your week's work. But I just preferred to see this implemented the right way and didn't want to leave it out there long enough for a whole bunch of folks to start using it. > But maybe I'll keep a copy of the files for historical value. +1 ;-) > In my little fixup exercise, I can state that the new datatype paradigm did > work nicely, provided your rules matched exactly what the types supported. > When that case held, what you got was zero effort datatype validation. > Things like that make creating robust tasks easier, and tasks with > consistency with existing tasks. Precisely the aim that I set out to achieve. > We can start next week with a utils class that performs the standard > validation stuff. Maybe FileUtils? I notice an implementation pattern emerging behind this proposition: setSrc(String srcFile) would perform new File(srcFile) initially. Later this was changed to FIleUtils.resolveFIle(srcFile). This approach was then replaced with setSrc(File srcFile) with the Introspector making the resolveFile call. Now you are suggesting we change setSrcFile(File) which currently does this.srcFile = srcFile to setSrcFile(File) which does this.srcFile = FileUtils.getSrcFile(srcFile). Wonder what it will lead to next... ;-) +0 on having it in a utility class because it provides APIs for task writers to choose to use, but it doesn't completely address the issue of automatic validation. > > -Steve > Cheers, Magesh -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
