sbailliez    02/01/08 14:07:44

  Modified:    src/main/org/apache/tools/ant ProjectHelper.java
  Log:
  Fix bad coding style.
  then/else parts of if statement and loop body must always been enclosed
  in a block statement.
  
  Revision  Changes    Path
  1.71      +9 -4      
jakarta-ant/src/main/org/apache/tools/ant/ProjectHelper.java
  
  Index: ProjectHelper.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/ProjectHelper.java,v
  retrieving revision 1.70
  retrieving revision 1.71
  diff -u -r1.70 -r1.71
  --- ProjectHelper.java        18 Dec 2001 20:19:07 -0000      1.70
  +++ ProjectHelper.java        8 Jan 2002 22:07:44 -0000       1.71
  @@ -328,7 +328,9 @@
                   project.addReference(name, project);
               }
   
  -            if (id != null) project.addReference(id, project);
  +            if (id != null) {
  +              project.addReference(id, project);
  +            }
   
               if (project.getProperty("basedir") != null) {
                   project.setBasedir(project.getProperty("basedir"));
  @@ -435,8 +437,9 @@
               target.setDescription(description);
               project.addTarget(name, target);
   
  -            if (id != null && !id.equals(""))
  +            if (id != null && !id.equals("")) {
                   project.addReference(id, target);
  +            }
   
               // take care of dependencies
   
  @@ -666,8 +669,9 @@
   
       public static void configure(Object target, AttributeList attrs, 
                                    Project project) throws BuildException {
  -        if( target instanceof TaskAdapter )
  +        if( target instanceof TaskAdapter ) {
               target=((TaskAdapter)target).getProxy();
  +        }
   
           IntrospectionHelper ih = 
               IntrospectionHelper.getHelper(target.getClass());
  @@ -709,8 +713,9 @@
               return;
           }
   
  -        if(target instanceof TaskAdapter)
  +        if(target instanceof TaskAdapter) {
               target = ((TaskAdapter) target).getProxy();
  +        }
   
           IntrospectionHelper.getHelper(target.getClass()).addText(project, 
target, text);
       }
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to