If the ds basedir has already been resolved, you probably don't need to resolve it again so this approach may be more efficient.
Conor > -----Original Message----- > From: Erik Hatcher [mailto:[EMAIL PROTECTED] > Sent: Wednesday, 6 February 2002 10:20 AM > To: Ant Developers List > Subject: Re: cvs commit: > jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs CopyTest.java > > > Nope, no reason.... I was just following along with the standard pattern > I've seen in other places for that particular patch. > > > ----- Original Message ----- > From: "Magesh Umasankar" <[EMAIL PROTECTED]> > To: "Ant Developers List" <[EMAIL PROTECTED]> > Sent: Tuesday, February 05, 2002 4:32 PM > Subject: cvs commit: > jakarta-ant/src/testcases/org/apache/tools/ant/taskdefs > CopyTest.java > > > > > ehatcher 02/02/04 16:56:00 > > > > > > Modified: src/main/org/apache/tools/ant/taskdefs Copy.java > > > src/etc/testcases/taskdefs copy.xml > > > src/testcases/org/apache/tools/ant/taskdefs > CopyTest.java > > > > > > > if (srcFiles.length > 0) { > > > if (file == null) { > > > - file = new File(srcFiles[0]); > > > + file = new File(ds.getBasedir(), > srcFiles[0]); > > > filesets.removeElementAt(0); > > > } else { > > > throw new BuildException( > > > > Any specific reason why FileUtils.resolveFile is not > > being used instead of new File(...)? > > > > Cheers, > > Magesh > > > > **************************************************** > > * Atom Bomb: An invention to end all inventions. * > > **************************************************** > > > > > > -- > > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > > > > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
