Re: echoproperties

[Ingmar J Stein]

> Once the task is JDK 1.1 compatible, I'm a +1, for what it counts.

Done. I added the putAll method to o.a.t.a.util.CollectionUtils as
Stefan suggested and merged his changes in the testcase.

Here are the patches against he beta1 codebase.

Cheers,
Ingmar

EchoPropertiesTest.java.diff
Description: Binary data

EchoProperties.java.diff
Description: Binary data

echoproperties.xml.diff
Description: Binary data

CollectionUtils.java.diff
Description: Binary data

EchoPropertiesTest.class
Description: Binary data

echoproperties.properties
Description: Binary data

<project name="test" default="def" basedir=".">

  <target name="def">
  </target>

  <target name="setup">
    <property name="a.set" value="true" />
    <property name="b.set" value="false" />
  </target>

  <target name="testEchoToLog" depends="setup">
    <echoproperties />
  </target>

  <target name="testEchoToLogXml" depends="setup">
    <echoproperties format="xml" />
  </target>

  <target name="testReadAndEchoToLog" depends="setup">
    <echoproperties srcfile="echoproperties.properties" />
  </target>

  <target name="testReadBadFile" depends="setup">
    <echoproperties srcfile="." />
  </target>

  <target name="testReadBadFileFail" depends="setup">
    <echoproperties srcfile="." failonerror="yes" />
  </target>

  <target name="testReadBadFileNoFail" depends="setup">
    <echoproperties srcfile="." failonerror="no" />
  </target>

  <target name="testEchoToBadFile" depends="setup">
    <echoproperties destfile="." />
  </target>

  <target name="testEchoToBadFileFail" depends="setup">
    <echoproperties destfile="." failonerror="yes" />
  </target>

  <target name="testEchoToBadFileNoFail" depends="setup">
    <echoproperties destfile="." failonerror="no" />
  </target>

  <target name="testEchoToGoodFile" depends="setup">
    <echoproperties destfile="test.properties" />
  </target>

  <target name="testEchoToGoodFileXml" depends="setup">
    <echoproperties destfile="test.xml" format="xml" />
  </target>

  <target name="testEchoToGoodFileFail" depends="setup">
    <echoproperties destfile="test.properties" failonerror="yes" />
  </target>

  <target name="testEchoToGoodFileNoFail" depends="setup">
    <echoproperties destfile="test.properties" failonerror="no" />
  </target>

  <target name="testEchoPrefix" depends="setup">
    <echoproperties destfile="test-prefix.properties" prefix="a." />
  </target>

  <target name="cleanup">
    <delete file="test.properties" failonerror="no" />
    <delete file="test-prefix.properties" failonerror="no" />
    <delete file="test.xml" failonerror="no" />
  </target>

</project>

EchoProperties.java
Description: Binary data

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>