Hello:
Enclosed please find my updated patch for "build.xml" (in handy single-patch format :-)
It is a minor change, but with significant goodness:
- TraX dependent code will now _compile_ with only the TraX API present (obviously it will not _run_ the associated tests unless a TraX IMPLEMENTATION is present)
Without the patch, classes that USE the TraX API like sitraka and TraXliaison won't even COMPILE without Xalan present.
This means that you need xalan to build them which is an artificial limitation.
- Allows TraX dependent tests to be run as long as any TraX-compliant processor is present in the classpath.
I have tested this out the wazzoo:
Windows 2000 + Java 1.3.1_03 - with no TraX - with Xalan2 (2.3.1) - with Saxon (6.5.2)
Red Hat Linux 7.2 + Java 1.3.1_03 - with no TraX - with Xalan2 (2.3.1) - with Saxon (6.5.2)
In all six cases, I bootstrapped from scratch, ran a build, then did "ant test" and ran all of the tests (omitting the ones below).
I did notice some interesting issues, but none relevant to the patch:
- FileUtilsTest fails for me (on Windows 2000 only) in setSetLastModified
- JavaTest hangs for me (on Linux only)
- InitializeClassTest hangs for me (on Linux only)
- on Windows only, saxon must be LAST in the path. I believe this is because saxon includes all of the JAXP library
in the same jar (not unbundled like xalan) and its JAXP is an earlier version that has win32 uri-resolver bugs. Michael
Kay has indicated to me in an email that this will be fixed in the next release.
--Craeg
Erik Hatcher wrote:
I've committed the changes from Craeg's bootstrap and build patches and relocated xml-apis.jar to the lib directory. All is working fine for me with, even a full "build test" succeeded.
I'll be glad to help our further if there are still issues that need to be addressed, such as more refinements to build.xml as Craeg suggests.
Erik
Index: jakarta-ant/build.xml
===================================================================
RCS file: /home/cvspublic/jakarta-ant/build.xml,v
retrieving revision 1.304.2.11
diff -u -r1.304.2.11 build.xml
--- jakarta-ant/build.xml 28 May 2002 00:33:35 -0000 1.304.2.11
+++ jakarta-ant/build.xml 28 May 2002 01:51:13 -0000
@@ -335,7 +335,10 @@
classpathref="classpath"/>
</and>
</condition>
- <condition property="trax.present">
+ <available property="trax.present"
+ classname="javax.xml.transform.Transformer"
+ classpathref="classpath" />
+ <condition property="trax.impl.present">
<or>
<and>
<isset property="javax.xml.transform.TransformerFactory"/>
@@ -406,10 +409,6 @@
<available property="commons.logging.present"
classname="org.apache.commons.logging.LogFactory"
classpathref="classpath"/>
- <!-- this is just a way to check for a TraX implementation -->
- <available property="trax.impl.present"
-
resource="META-INF/services/javax.xml.transform.TransformerFactory"
- classpathref="classpath"/>
<available property="xalan.envcheck"
classname="org.apache.xalan.xslt.EnvironmentCheck"
classpathref="classpath" />
@@ -1282,11 +1281,11 @@
<!-- these tests need to be localised before being ran???? -->
<exclude name="${optional.package}/PvcsTest.java" />
- <!-- ehm, these are not really TraX tests but rather xalan2
tests..-->
+ <!-- These tests need a TraX implementation like xalan2 or saxon -->
<exclude name="${optional.package}/TraXLiaisonTest.java"
- unless="xalan2.present"/>
+ unless="trax.impl.present"/>
<exclude name="${optional.package}/XsltTest.java"
- unless="xalan2.present"/>
+ unless="trax.impl.present"/>
<!-- needs BSF to work -->
<exclude name="${optional.package}/XalanLiaisonTest.java"-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
