bodewig 2002/11/18 04:02:27
Modified: . WHATSNEW
src/main/org/apache/tools/ant/taskdefs/cvslib
ChangeLogTask.java
Log:
The cvschangelog task doesn't seem to report changes for the current
calendar day.
The problem lies in the fact that the exec'ed cvs command is in the form:
> cvs log "-d >=2002-11-7"
rather than:
> cvs log -d ">=2002-11-7"
The two commands return different results when changes have been made today!
PR: 14397
Submitted by: Paul Berrevoets <paul at swi.com>
Revision Changes Path
1.321 +2 -0 jakarta-ant/WHATSNEW
Index: WHATSNEW
===================================================================
RCS file: /home/cvs/jakarta-ant/WHATSNEW,v
retrieving revision 1.320
retrieving revision 1.321
diff -u -r1.320 -r1.321
--- WHATSNEW 15 Nov 2002 13:15:23 -0000 1.320
+++ WHATSNEW 18 Nov 2002 12:02:27 -0000 1.321
@@ -53,6 +53,8 @@
* <cvstagdiff> would throw a NullPointException if there had been no
differences.
+* <cvschangelog> could miss today's changes.
+
Other changes:
--------------
* <setproxy> lets you set the username and password for proxies that want
authentication
1.19 +5 -5
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java
Index: ChangeLogTask.java
===================================================================
RCS file:
/home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/cvslib/ChangeLogTask.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- ChangeLogTask.java 25 Jul 2002 15:21:10 -0000 1.18
+++ ChangeLogTask.java 18 Nov 2002 12:02:27 -0000 1.19
@@ -249,9 +249,10 @@
new SimpleDateFormat("yyyy-MM-dd");
// We want something of the form: -d ">=YYYY-MM-dd"
- final String dateRange = "-d >="
- + outputDate.format(m_start);
+ final String dateRange = ">=" + outputDate.format(m_start);
+ // Supply '-d' as a separate argument - Bug# 14397
+ command.createArgument().setValue("-d");
command.createArgument().setValue(dateRange);
}
@@ -275,8 +276,7 @@
final RedirectingStreamHandler handler =
new RedirectingStreamHandler(parser);
- log("ChangeLog command: [" + command.toString() + "]",
- Project.MSG_VERBOSE);
+ log(command.describeCommand(), Project.MSG_VERBOSE);
final Execute exe = new Execute(handler);
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
