Sounds fine to me. I personally rarely use any kind of logging/listener for my builds, but its definitely handy when needed like in the case of using Ant within Tomcat.

Keep in mind that your previous change, and your proposed changes break backwards compatibility in case anyone had already set up filters for Commons Logging, but thats not very likely to be an issue anyone would complain about.

        Erik

On Wednesday, January 8, 2003, at 01:13 PM, Costin Manolache wrote:
Erik ( and others ):

What about using the task name and for the channel names :

Something like:

 ant.tasks.TASK_NAME.TARGET_NAME ( ant.tasks.copy.init instead of
org.apache.tools.ant.taskdefs.Copy.init )

Also - what about adding the project name - so you can toggle debugging ( or
silence ) for a task globally, only in a specific target, or in a specific
target in a specific project.


It's easier to type...
Probably same thing for target and project - but that won't be used too
much.

Costin


Erik Hatcher wrote:

On Tuesday, January 7, 2003, at 11:35 PM, [EMAIL PROTECTED] wrote:
costin 2003/01/07 20:35:22

[...]

+import org.apache.tools.ant.*;

Our conventions are to expand out all imports, rather than using .*

  +public class CommonsLoggingListener implements BuildListener,
BuildLogger {

This could be shortened to a single implement of BuildLogger, since that in turn implements BuildListener, FYI.

Glad to see this listener/logger getting some interest!

Erik



--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>





--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>



Reply via email to