DO NOT REPLY [Bug 16081] New: - The cvstagdiff task *should* usefully echo the requested package and cvsroot in its XML output

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16081>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16081

The cvstagdiff task *should* usefully echo the requested package and cvsroot in 
its XML output

           Summary: The cvstagdiff task *should* usefully echo the requested
                    package and cvsroot in its XML output
           Product: Ant
           Version: 1.5.1
          Platform: PC
        OS/Version: Windows NT/2K
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Core tasks
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


The cvstagdiff task does not echo the supplied package and cvsroot attributes 
in the XML output. This makes it difficult to use the remaining data in the 
output XML file to prepare queries for CVSWeb, ViewCVS or commands for CVS. A 
current (1.5.1) sample output for the the following build.xml segment:

<cvstagdiff cvsroot   = ":pserver:/usr/local/cvs"
            destfile  = "tagdiff.xml"
            package   = "myproject"
            startdate = "'2003-01-14 10:14:57'"
            enddate   = "'2003-01-14 10:23:28'" />

is:

<?xml version="1.0" encoding="UTF-8"?>
<tagdiff startDate="'2003-01-14 10:14:57'" endDate="'2003-01-14 10:23:28'" >
  <entry>
    <file>
      <name>buildfiles/libbuild.xml</name>
        <revision>1.27</revision>
        <prevrevision>1.26</prevrevision>
    </file>
  </entry>
</tagdiff>
 
The partial path to the file (buildfiles/libbuild.xml) is insufficient to 
independently locate the file without implicitly knowing the cvsroot and the 
package (module) name.

It would be more useful to output:

<?xml version="1.0" encoding="UTF-8"?>
<tagdiff startDate="'2003-01-14 10:14:57'" 
         endDate="'2003-01-14 10:23:28'"
         cvsroot=":pserver:/usr/local/cvs" 
         package="myproject" >
  <entry>
    <file>
      <name>buildfiles/libbuild.xml</name>
        <revision>1.27</revision>
        <prevrevision>1.26</prevrevision>
    </file>
  </entry>
</tagdiff>

With this information it is possible to reconstruct from an independent parsing 
the XML that the file revisons can be recovered from:

:pserver:/usr/local/cvs/myproject/buildfiles/libbuild.xml

This enhancement is easily added by inserting two lines in CvsTagDiff.java in 
the method writetagDiff at lines 473, 474:

            writer.print("cvsroot=\"" + m_cvs.getCvsRoot() + "\" ");
            writer.print("package=\"" + m_package + "\" ");

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>