Janine, I'm going to look at the diff's and see what change was made which "broke" this in 4.x, but I'm thinking that the 4.x behavior is "better" ... HTML comment parsing can get gnarly, especially if you want to allow things like nested comments, etc. However, if you say it worked in 3.x, then maybe this was broken accidentally in 4.x.
If it was intentionally changed in 4.x, then I'd like to leave it the way it is. Otherwise, I'll ask you to file a bug and we'll take care of it. -- Dossy On 2004.09.01, Janine A Sisk <[EMAIL PROTECTED]> wrote: > I can now confirm that this happens with 4.0.8a as well. Everything > else appears to be working fine (knock wood). > > janine > > On Sep 1, 2004, at 5:57 PM, Janine A Sisk wrote: > > >This isn't an earthshaking thing, but it was unexpected and therefore > >noteworthy, to me at least. > > > >The home page of one of our client's sites had some code like this in > >an .adp: > > > ><!-- if @user_currency@ eq pounds> > >some stuff > ></if> > > > ><if @user_currency@ eq dollars> > >other stuff > ></if--> > > > >For those not familiar, this is the OpenACS templating syntax. And > >yes, it should have been an if-else, but this client writes his own > >display code and I avert my eyes whenever possible. ;) > > > >The above was fine in AOLserver 3.3, but when I upgraded the site to > >4.0.7 I was getting a "no such error" variable on a multiple that I > >knew was being set, one that was first referenced after the above block > >of code. After some trial and error I finally figured out that if I > >changed the code to this, it was ok: > > > ><!-- if @user_currency@ eq pounds> > >some stuff > ></if--> > > > ><!--if @user_currency@ eq dollars> > >other stuff > ></if--> > > > >I'm not exactly sure what caused the problem - a difference in how the > >.adps were parsed, I imagine, but I didn't get into that level of > >detail. > > > >Dossy, do you want me to file a bug on this? Or would you call the > >original construct a bug, and the fact that it no longer works an > >improvement? > > > >janine -- Dossy Shiobara mail: [EMAIL PROTECTED] Panoptic Computer Network web: http://www.panoptic.com/ "He realized the fastest way to change is to laugh at your own folly -- then you can let go and quickly move on." (p. 70) -- AOLserver - http://www.aolserver.com/ To Remove yourself from this list, simply send an email to <[EMAIL PROTECTED]> with the body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject: field of your email blank.
