Tom Jackson schrieb:
Andrew,
Okay, great! The changes should probably be divided into two patches:
good idea.
While the changes in queue.c are somewhat non-obvious
the changes related to adprequest.c and adpeval.c are more
clear to me. They address the original problem.
i was not able to follow the full discussion and most likely one needs
more thoughts and largers test cases to consider. Do i understand correctly:
- when either the POST_AUTH filter or the request returns != NS_OK
the server returns a 500 error
- if there was an earlier "ns_return XXX", it is ignored.
NsRunFilters retuns either NS_OK or NS_FILTER_BREAK, NS_FILTER_TRACE or
NS_FILTER_RETURN. Don't we have to deal with the other non-ok cases?
More filters and the traces are run, when the status is NS_OK
or NS_FILTER_RETURN. If i look at the code, i wonder,
what happens with filters and traces for status codes like
NS_FORBIDDEN, NS_UNAUTHORIZED, or NS_SHUTDOWN?
Have you checked what happens, when a Ns_ConnRunRequest
ended in Tcl with a "return", "break" or "continue"?
-gustaf neumann
--
AOLserver - http://www.aolserver.com/
To Remove yourself from this list, simply send an email to
<lists...@listserv.aol.com> with the
body of "SIGNOFF AOLSERVER" in the email message. You can leave the Subject:
field of your email blank.
