The following reply was made to PR config/4248; it has been noted by GNATS.
From: Raymond S Brand <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: Re: config/4248: ServerSignature directive only effective in main
server config.
Date: Thu, 22 Apr 1999 13:25:37 -0400
The following patch makes the ServerSignature directive work as documented.
Please include this in 1.3.7, if possible.
Raymond S Brand
P.S. Please use [EMAIL PROTECTED] for correspondence.
diff -ur apache_1.3.6-orig/src/include/http_core.h
apache_1.3.6-rsbx/src/include/http_core.h
--- apache_1.3.6-orig/src/include/http_core.h Wed Mar 10 15:18:55 1999
+++ apache_1.3.6-rsbx/src/include/http_core.h Thu Apr 22 12:54:27 1999
@@ -251,7 +251,8 @@
unsigned long limit_req_body; /* limit on bytes in request msg body */
/* logging options */
- enum { srv_sig_off, srv_sig_on, srv_sig_withmail } server_signature;
+ enum { srv_sig_unset, srv_sig_off, srv_sig_on,
+ srv_sig_withmail } server_signature;
int loglevel;
/* Access control */
diff -ur apache_1.3.6-orig/src/main/http_core.c
apache_1.3.6-rsbx/src/main/http_core.c
--- apache_1.3.6-orig/src/main/http_core.c Fri Mar 19 18:54:08 1999
+++ apache_1.3.6-rsbx/src/main/http_core.c Thu Apr 22 13:02:09 1999
@@ -148,6 +148,9 @@
#ifdef WIN32
conf->script_interpreter_source = INTERPRETER_SOURCE_UNSET;
#endif
+
+ conf->server_signature = srv_sig_unset;
+
return (void *)conf;
}
@@ -271,6 +274,10 @@
}
#endif
+ if (new->server_signature != srv_sig_unset) {
+ conf->server_signature = new->server_signature;
+ }
+
return (void*)conf;
}
@@ -2483,7 +2490,8 @@
conf = (core_dir_config *)ap_get_module_config(r->per_dir_config,
&core_module);
- if (conf->server_signature == srv_sig_off) {
+ if ((conf->server_signature == srv_sig_off)
+ || (conf->server_signature == srv_sig_unset)) {
return "";
}
--