The first of these changes is correct, the second isn't. That 0xffffffff
is deliberate -- it is literally the address 255.255.255.255, which if
you use as a virtualhost address will become the "default" server used
when the ip doesn't match other vhosts.
Dean
In message <[EMAIL PROTECTED]>, Roy Fielding writes:
>fielding 96/12/04 16:33:29
>
> Modified: src http_config.c http_main.c
> Log:
> Replaced non-portable use of 0xffffffff with portable INADDR_NONE
> like we did for the bug in util.c.
>
> Revision Changes Path
> 1.36 +1 -1 apache/src/http_config.c
>
> Index: http_config.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/http_config.c,v
> retrieving revision 1.35
> retrieving revision 1.36
> diff -C3 -r1.35 -r1.36
> *** http_config.c 1996/12/01 20:28:18 1.35
> --- http_config.c 1996/12/05 00:33:24 1.36
> ***************
> *** 861,867 ****
> #else
> my_addr = inet_addr(w);
> #endif
> ! if (my_addr != ((unsigned long) 0xffffffff)) {
> sar = pcalloc( p, sizeof( server_addr_rec ) );
> **paddr = sar;
> *paddr = &sar->next;
> --- 861,867 ----
> #else
> my_addr = inet_addr(w);
> #endif
> ! if (my_addr != INADDR_NONE) {
> sar = pcalloc( p, sizeof( server_addr_rec ) );
> **paddr = sar;
> *paddr = &sar->next;
>
>
>
> 1.93 +1 -1 apache/src/http_main.c
>
> Index: http_main.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/http_main.c,v
> retrieving revision 1.92
> retrieving revision 1.93
> diff -C3 -r1.92 -r1.93
> *** http_main.c 1996/12/01 20:28:26 1.92
> --- http_main.c 1996/12/05 00:33:26 1.93
> ***************
> *** 1245,1251 ****
> sar->host_addr.s_addr == server_ip.s_addr) &&
> (sar->host_port == 0 || sar->host_port == port)) {
> return virt;
> ! } else if ( sar->host_addr.s_addr == 0xffffffff ) {
> /* this is so that you can build a server that is the
> "default" for any interface which isn't explicitly
> specified. So that you can implement "deny anything
> --- 1245,1251 ----
> sar->host_addr.s_addr == server_ip.s_addr) &&
> (sar->host_port == 0 || sar->host_port == port)) {
> return virt;
> ! } else if ( sar->host_addr.s_addr == INADDR_NONE ) {
> /* this is so that you can build a server that is the
> "default" for any interface which isn't explicitly
> specified. So that you can implement "deny anything
>
>
>
>
