dirkx 99/02/02 08:15:52
Modified: . STATUS
src/modules/standard mod_log_config.c
Log:
Holed up in Africa. No flights out. Bored. Fetched and tried some patches.
More Tomorrow
Revision Changes Path
1.609 +17 -10 apache-1.3/STATUS
Index: STATUS
===================================================================
RCS file: /home/cvs/apache-1.3/STATUS,v
retrieving revision 1.608
retrieving revision 1.609
diff -u -r1.608 -r1.609
--- STATUS 1999/01/31 21:54:01 1.608
+++ STATUS 1999/02/02 16:15:50 1.609
@@ -1,5 +1,5 @@
1.3 STATUS:
- Last modified at [$Date: 1999/01/31 21:54:01 $]
+ Last modified at [$Date: 1999/02/02 16:15:50 $]
Release:
@@ -48,7 +48,7 @@
* Roy's [PATCH] Core dump with Language Negotiation?!?
Message-ID: <[EMAIL PROTECTED]>
- Status: Roy +1
+ Status: Roy +1 Dirkx +1
* Tony Finch's [PATCH] to mod_log_config.c to get both the 1.3.3
behaviour of %v and the 1.3.4 behaviour as %V.
@@ -61,7 +61,7 @@
* Ralf's adjusted version of Fred's Add strip flags variables
Message-ID: <[EMAIL PROTECTED]>
- Status: Ralf +1
+ Status: Ralf +1 Dirkx +1
* Fred's PATCH: Add strip flags variables in Makefile.tmpl
Message-ID: <[EMAIL PROTECTED]>
@@ -69,7 +69,7 @@
* Fred's PATCH: man page section numbers
Message-ID: <[EMAIL PROTECTED]>
- Status: Ralf +1, Roy +1
+ Status: Ralf +1, Roy +1, Dirkx +1
* Fred's PATCH: Add cgidir, htdocsdir, iconsdir variables in
Makefile.tmpl
Message-ID: <[EMAIL PROTECTED]>
@@ -77,7 +77,7 @@
* Fred's PATCH: Add Mac OS X Server Layout file layout
Message-ID: <[EMAIL PROTECTED]>
- Status: Roy +1
+ Status: Roy +1, Dirkx +0
* Jim Patterson's patch to make mod_info work on Win32
Message-ID: PR#1442
@@ -93,7 +93,7 @@
* Ronald Tschalär's ap_uuencode() bugfix
Message-ID: PR#3411
- Status: Lars +1 (on concept)
+ Status: Lars +1 (on concept), Dirkx +1
* Michael van Elst's patch [PR#3160] to improve mod_rewrite's
in-core cache handling by using a hash table.
@@ -171,12 +171,16 @@
Status: Lars' patch was vetoed. Roy and Dean think that it is
probably another buffer magic number error and should be
tested to find out and, if so, fixed like it was in core.
+ Dirkx: cannot reproduce this at all.
* ap_escape_html() always duplicates the string, even when there is
no change and the caller would be happy to use the original.
What is needed is a separate interface for "don't need a dup"
situations, like just about everywhere we use it in bvputs and
bputs calls.
+ dirkx: -1 (as some of the modules from modules.apache.org seem
+ (rightly?) to assume that they can modify the returned escaped
+ string whilst relying on the passed string not to be damaged.
* Should we disallow requests with bogus characters in the method?
See <[EMAIL PROTECTED]>
@@ -209,17 +213,17 @@
* Maybe a http_paths.h file? See
<[EMAIL PROTECTED]>
- +1: Brian, Paul, Ralf, Martin
+ +1: Brian, Paul, Ralf, Martin, Dirkx
+0: Jim (not for 1.3.0)
* Release builds: Should we provide Configuration or not?
Should we 'make all suexec' in src/support?
- +1: Brian, Jim, Ken +1 (possible suexec path issue, though)
+ +1: Brian, Jim, Dirkx, Ken +1 (possible suexec path issue, though)
* root's environment is inherited by the Apache server. Jim & Ken
think we should recommend using 'env' to build the
appropriate environment. Marc and Alexei don't see any
- big deal. Martin says that not every "env" has a -u flag.
+ big deal. Martin says that not every "env" has a -u flag.
* Marc's socket options like source routing (kill them?)
Marc, Martin say Yes
@@ -235,7 +239,9 @@
field is r->content_languages. Heck it's not even mentioned in
apache-devsite/mmn.txt when we got content_languages (note the s!).
The proposal is to remove r->content_language:
- Status: Paul +1, Ralf +1, Ken +1, Martin +1
+ Status: Paul +1, Ralf +1, Ken +1, Martin +1, Dirkx +1 (I could
+ not find ANY module which uses it and which (still) compiles
+ after the config change.)
- child_exit() is redundant, it can be implemented via cleanups. It is
not "symmetric" in the sense that there is no exit API method to go
@@ -260,6 +266,7 @@
unless we warn people in big nasty letters to add
PassEnv TZ to their config files "just in case"
and hope they do it :)
+ Dirkx: Is not this the same issue about maintaining your 'env' ?
* In ap_bclose() there's no test that (fb->fd != -1) -- so it's
possible that it'll do something completely bogus when it's
1.71 +3 -0 apache-1.3/src/modules/standard/mod_log_config.c
Index: mod_log_config.c
===================================================================
RCS file: /home/cvs/apache-1.3/src/modules/standard/mod_log_config.c,v
retrieving revision 1.70
retrieving revision 1.71
diff -u -r1.70 -r1.71
--- mod_log_config.c 1999/01/01 19:05:10 1.70
+++ mod_log_config.c 1999/02/02 16:15:51 1.71
@@ -397,6 +397,9 @@
return ap_pstrdup(r->pool, tstr);
}
+/* XXXX: bullshit. needs to be done using gettimeofday() when possible
+ * and not this time, as it is the time the LOGging hapens.
+ */
static const char *log_request_duration(request_rec *r, char *a)
{
return ap_psprintf(r->pool, "%ld", time(NULL) - r->request_time);
