dougm 2002/06/03 17:44:24
Modified: lib/Apache compat.pm
t/response/TestApache compat2.pm
todo api.txt
Log:
add Apache->define compat method
Revision Changes Path
1.60 +5 -0 modperl-2.0/lib/Apache/compat.pm
Index: compat.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -r1.59 -r1.60
--- compat.pm 3 Jun 2002 18:27:03 -0000 1.59
+++ compat.pm 4 Jun 2002 00:44:23 -0000 1.60
@@ -99,6 +99,11 @@
return Symbol::gensym();
}
+sub define {
+ shift if @_ == 2;
+ exists_config_define(@_);
+}
+
package Apache::Constants;
use Apache::Const ();
1.16 +5 -1 modperl-2.0/t/response/TestApache/compat2.pm
Index: compat2.pm
===================================================================
RCS file: /home/cvs/modperl-2.0/t/response/TestApache/compat2.pm,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- compat2.pm 3 Jun 2002 18:27:03 -0000 1.15
+++ compat2.pm 4 Jun 2002 00:44:23 -0000 1.16
@@ -24,7 +24,7 @@
sub handler {
my $r = shift;
- plan $r, tests => 46;
+ plan $r, tests => 47;
$r->send_http_header('text/plain');
@@ -233,6 +233,10 @@
ok t_cmp(!$r->main, $r->is_main,
'$r->is_main');
+
+ ok t_cmp(Apache::exists_config_define('MODPERL2'),
+ Apache->define('MODPERL2'),
+ 'Apache->define');
#note these are not actually part of the tests
#since i think on platforms where crypt is not supported,
1.24 +0 -4 modperl-2.0/todo/api.txt
Index: api.txt
===================================================================
RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- api.txt 25 May 2002 17:49:03 -0000 1.23
+++ api.txt 4 Jun 2002 00:44:23 -0000 1.24
@@ -40,10 +40,6 @@
1.x ht_time compat. should we just leave as is or see if ht_time can
be changed to not require a pool?
-Apache->define:
-exists as Apache::exists_config_define, which should stay,
-Apache::compat could implement a wrapper.
-
$r->document_root:
cannot currently be modified. requires locking since it is part of
the per-server config structure which is shared between threads
