On Wed, Feb 22, 2012 at 01:14:09PM -0800, John Johansen wrote: > On 02/22/2012 01:10 PM, Kees Cook wrote: > > Hi John, > > > > On Wed, Feb 22, 2012 at 09:22:45AM -0800, John Johansen wrote: > >> +static struct aa_fs_entry aa_fs_entry_features[] = { > >> + AA_FS_DIR("domain", aa_fs_entry_domain), > >> + AA_FS_FILE_BOOLEAN("namespaces", 1), > > > > If "namespaces" is going to change into a directory, perhaps just leave > > it out for now? > > > Hrmm yes we could do that, it would be a little cleaner. > > Originally I wasn't going to make it a directory but it felt cleaner to > group all the things that affect namespaces in one way or another together. > > So the clone flags patch (not posted yet), pivot_root, chroot, apparmor > namespaces, etc.
Well, since the patch that changes namespaces into a directory will be sent up at the same time, it's probably fine to just leave it as-is. -- Kees Cook -- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor